Differential D35280

cleanup: remove expired versions of OpenJDK (12 through 16)
ClosedPublic
Actions

Authored by rene on May 21 2022, 2:58 PM.

Tags

None

Referenced Files

	F81492624: D35280.diff
	Wed, Apr 17, 4:25 AM

	Unknown Object (File)
	Wed, Mar 20, 2:36 AM

	Unknown Object (File)
	Mar 15 2024, 3:00 PM

	Unknown Object (File)
	Mar 14 2024, 2:48 PM

	Unknown Object (File)
	Mar 14 2024, 2:47 PM

	Unknown Object (File)
	Mar 14 2024, 2:44 PM

	Unknown Object (File)
	Mar 11 2024, 2:39 AM

	Unknown Object (File)
	Mar 11 2024, 2:37 AM

View All 52 Files

Subscribers

Details

Reviewers

jwb
yuri
glewis
bryan_frimin.fr
rene

Group Reviewers

Commits

R11:c7d1c247d8ea: cleanup: remove expired versions of OpenJDK (12 through 16)

Summary

Adjust ports depending on expired versions of OpenJDK:

biology/snpeff: 12+ -> 11+
devel/RStudio: 12 -> 11
www/closure-compiler: 13 -> 11+

Allow java/openjdk17 to use java/openjdk17-bootstrap on i386
too, this builds just fine on 13.1-i386

Remove jdk12-doc as it is no longer relevant.

Clean up Java version calculations in bsd.java.mk

Test Plan

make index

build java/openjdk17 on i386

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 45658
Build 42546: arc lint + arc unit

Event Timeline

rene created this revision.May 21 2022, 2:58 PM

Herald added a reviewer: portmgr. · View Herald TranscriptMay 21 2022, 2:58 PM

Herald added a subscriber: mat. · View Herald Transcript

rene requested review of this revision.May 21 2022, 2:58 PM

Harbormaster completed remote builds in B45658: Diff 106240.May 21 2022, 2:58 PM

note to self: don't forget to update MOVED

Add MOVED lines and update bsd.default-versions.mk

Harbormaster completed remote builds in B45664: Diff 106256.May 22 2022, 9:46 AM

The SnpEff site clearly states a Java 12 requirement: http://pcingola.github.io/SnpEff/

So I think this will have to go to 17+.

biology/snpeff: use Java 17 or later.

Harbormaster completed remote builds in B45665: Diff 106260.May 22 2022, 1:59 PM

Rebase

Harbormaster completed remote builds in B45673: Diff 106287.May 23 2022, 5:59 PM

Looks good to me. I had some minor optional comments. Thanks for doing this René!

MOVED
17175–17179 ↗	(On Diff #106287)	This is true for 12, 14, and 16. While Oracle no longer release updates for 13 and 15, the repositories are getting back/forward ports of security fixes. I believe this is being done by Azul Systems. The FreeBSD ports have been following these updates as well, in general. That said, I don't get the feeling that they are being used by anyone and they are not official LTS releases. We'd also need some way to bootstrap them if we were to keep them since all of these releases need bootstrapping by the previous version. So I think it is the right thing to do to remove them.
java/openjdk17/Makefile
116–119	This conditional seems like it should just be deleted given that openjdk16 is being removed and be collapsed into the line above: BOOTSTRAP_JDKS= ${LOCALBASE}/openjdk17 ${LOCALBASE}/bootstrap-openjdk17
129–134	Can we just delete this inner conditional now? It seems like it is pretty much covered by ONLY_FOR_ARCHS

rene marked 3 inline comments as done.May 24 2022, 7:35 PM

rene added inline comments.

java/openjdk17/Makefile
129–134	Sure, I wasn't sure if there was some edge case left.

java/openjdk17: simplify bootstrap logic

Harbormaster completed remote builds in B45695: Diff 106328.May 24 2022, 7:36 PM

MOVED: finalize dates

Harbormaster completed remote builds in B45696: Diff 106329.May 24 2022, 8:08 PM

Self-accept to close.

This revision is now accepted and ready to land.May 24 2022, 9:17 PM

rene closed this revision.May 24 2022, 9:17 PM

rene added a commit: R11:c7d1c247d8ea: cleanup: remove expired versions of OpenJDK (12 through 16).Jul 31 2022, 12:03 AM

Revision Contents
Changeset List

Path

Size

Mk/

22 lines

biology/

snpeff/

2 lines

devel/

RStudio/

2 lines

java/

6 lines

jdk12-doc/

openjdk12/

files/

extra-patch-src_hotspot_cpu_ppc_vm__version__ppc.hpp

patch-10-af5c725b

patch-changeset-57932

patch-changeset-57994

patch-commit-34ae46e2bca

patch-commit-c484d890428

patch-configure

patch-make_autoconf_flags-cflags.m4

patch-make_autoconf_libraries.m4

patch-src_hotspot_os__cpu_bsd__ppc_bytes__bsd__ppc.inline.hpp

patch-src_hotspot_os_bsd_os__bsd.cpp

patch-src_java.desktop_unix_classes_sun_awt_X11_XlibWrapper.java

patch-src_java.desktop_unix_native_libawt__xawt_xawt_XlibWrapper.c

patch-src_jdk.hotspot.agent_bsd_native_libsaproc_BsdDebuggerLocal.c

openjdk13/

files/

extra-patch-src_hotspot_cpu_ppc_vm__version__ppc.hpp

patch-configure

patch-make_autoconf_flags-cflags.m4

patch-make_autoconf_libraries.m4

patch-src_hotspot_os_bsd_os__bsd.cpp

openjdk14/

files/

extra-patch-src_hotspot_cpu_ppc_vm__version__ppc.hpp

patch-changeset-57932

patch-changeset-57994

patch-commit-c484d890428

patch-commit-f8a9602a0a6

patch-configure

patch-make_autoconf_flags-cflags.m4

patch-make_autoconf_libraries.m4

patch-make_lib_Awt2dLibraries.gmk

patch-src_hotspot_os__cpu_bsd__ppc_bytes__bsd__ppc.inline.hpp

patch-src_hotspot_os_bsd_os__bsd.cpp

patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c

patch-src_java.desktop_unix_classes_sun_awt_X11_XlibWrapper.java

patch-src_java.desktop_unix_native_libawt__xawt_xawt_XlibWrapper.c

patch-src_jdk.hotspot.agent_bsd_native_libsaproc_BsdDebuggerLocal.cpp

openjdk15/

files/

extra-patch-src_hotspot_cpu_ppc_vm__version__ppc.hpp

patch-configure

patch-make_autoconf_flags-cflags.m4

patch-make_autoconf_libraries.m4

patch-make_modules_java.desktop_lib_Awt2dLibraries.gmk

patch-src_hotspot_os_bsd_os__bsd.cpp

patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c

openjdk16/

files/

extra-patch-src_hotspot_cpu_ppc_vm__version__ppc.hpp

patch-configure

patch-make_autoconf_flags-cflags.m4

patch-make_autoconf_libraries.m4

patch-make_modules_java.desktop_lib_Awt2dLibraries.gmk

patch-src_hotspot_os_bsd_os__bsd.cpp

patch-src_hotspot_share_adlc_formsopt.cpp

patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c

openjdk17/

8 lines

www/

closure-compiler/

2 lines

Diff 106240

Mk/bsd.java.mk

Loading...

biology/snpeff/Makefile

Loading...

devel/RStudio/Makefile

Loading...

java/Makefile

Loading...

java/jdk12-doc/Makefile

Loading...

java/jdk12-doc/distinfo

Loading...

java/jdk12-doc/pkg-descr

Loading...

java/openjdk12/Makefile

Loading...

java/openjdk12/distinfo

Loading...

java/openjdk12/files/cacerts

Loading...

java/openjdk12/files/extra-patch-src_hotspot_cpu_ppc_vmversionppc.hpp

Loading...

java/openjdk12/files/patch-10-af5c725b

Loading...

java/openjdk12/files/patch-changeset-57932

Loading...

java/openjdk12/files/patch-changeset-57994

Loading...

java/openjdk12/files/patch-commit-34ae46e2bca

Loading...

java/openjdk12/files/patch-commit-c484d890428

Loading...

java/openjdk12/files/patch-configure

Loading...

java/openjdk12/files/patch-make_autoconf_flags-cflags.m4

Loading...

java/openjdk12/files/patch-make_autoconf_libraries.m4

Loading...

java/openjdk12/files/patch-src_hotspot_os__cpu_bsd__ppc_bytesbsdppc.inline.hpp

Loading...

java/openjdk12/files/patch-src_hotspot_os_bsd_os__bsd.cpp

Loading...

java/openjdk12/files/patch-src_java.desktop_unix_classes_sun_awt_X11_XlibWrapper.java

Loading...

java/openjdk12/files/patch-src_java.desktop_unix_native_libawt__xawt_xawt_XlibWrapper.c

Loading...

java/openjdk12/files/patch-src_jdk.hotspot.agent_bsd_native_libsaproc_BsdDebuggerLocal.c

Loading...

java/openjdk12/pkg-descr

Loading...

java/openjdk12/pkg-message

Loading...

java/openjdk13/Makefile

Loading...

java/openjdk13/distinfo

Loading...

java/openjdk13/files/cacerts

Loading...

java/openjdk13/files/extra-patch-src_hotspot_cpu_ppc_vmversionppc.hpp

Loading...

java/openjdk13/files/patch-configure

Loading...

java/openjdk13/files/patch-make_autoconf_flags-cflags.m4

Loading...

java/openjdk13/files/patch-make_autoconf_libraries.m4

Loading...

java/openjdk13/files/patch-src_hotspot_os_bsd_os__bsd.cpp

Loading...

java/openjdk13/pkg-descr

Loading...

java/openjdk13/pkg-message

Loading...

java/openjdk14/Makefile

Loading...

java/openjdk14/distinfo

Loading...

java/openjdk14/files/cacerts

Loading...

java/openjdk14/files/extra-patch-src_hotspot_cpu_ppc_vmversionppc.hpp

Loading...

java/openjdk14/files/patch-changeset-57932

Loading...

java/openjdk14/files/patch-changeset-57994

Loading...

java/openjdk14/files/patch-commit-c484d890428

Loading...

java/openjdk14/files/patch-commit-f8a9602a0a6

Loading...

java/openjdk14/files/patch-configure

Loading...

java/openjdk14/files/patch-make_autoconf_flags-cflags.m4

Loading...

java/openjdk14/files/patch-make_autoconf_libraries.m4

Loading...

java/openjdk14/files/patch-make_lib_Awt2dLibraries.gmk

Loading...

java/openjdk14/files/patch-src_hotspot_os__cpu_bsd__ppc_bytesbsdppc.inline.hpp

Loading...

java/openjdk14/files/patch-src_hotspot_os_bsd_os__bsd.cpp

Loading...

java/openjdk14/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c

Loading...

java/openjdk14/files/patch-src_java.desktop_unix_classes_sun_awt_X11_XlibWrapper.java

Loading...

java/openjdk14/files/patch-src_java.desktop_unix_native_libawt__xawt_xawt_XlibWrapper.c

Loading...

java/openjdk14/files/patch-src_jdk.hotspot.agent_bsd_native_libsaproc_BsdDebuggerLocal.cpp

Loading...

java/openjdk14/pkg-descr

Loading...

java/openjdk14/pkg-message

Loading...

java/openjdk15/Makefile

Loading...

java/openjdk15/distinfo

Loading...

java/openjdk15/files/cacerts

Loading...

java/openjdk15/files/extra-patch-src_hotspot_cpu_ppc_vmversionppc.hpp

Loading...

java/openjdk15/files/patch-configure

Loading...

java/openjdk15/files/patch-make_autoconf_flags-cflags.m4

Loading...

java/openjdk15/files/patch-make_autoconf_libraries.m4

Loading...

java/openjdk15/files/patch-make_modules_java.desktop_lib_Awt2dLibraries.gmk

Loading...

java/openjdk15/files/patch-src_hotspot_os_bsd_os__bsd.cpp

Loading...

java/openjdk15/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c

Loading...

java/openjdk15/pkg-descr

Loading...

java/openjdk15/pkg-message

Loading...

java/openjdk16/Makefile

Loading...

java/openjdk16/distinfo

Loading...

java/openjdk16/files/cacerts

Loading...

java/openjdk16/files/extra-patch-src_hotspot_cpu_ppc_vmversionppc.hpp

Loading...

java/openjdk16/files/patch-configure

Loading...

java/openjdk16/files/patch-make_autoconf_flags-cflags.m4

Loading...

java/openjdk16/files/patch-make_autoconf_libraries.m4

Loading...

java/openjdk16/files/patch-make_modules_java.desktop_lib_Awt2dLibraries.gmk

Loading...

java/openjdk16/files/patch-src_hotspot_os_bsd_os__bsd.cpp

Loading...

java/openjdk16/files/patch-src_hotspot_share_adlc_formsopt.cpp

Loading...

java/openjdk16/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c

Loading...

java/openjdk16/pkg-descr

Loading...

java/openjdk16/pkg-message

Loading...

java/openjdk17/Makefile

Loading...

www/closure-compiler/Makefile

Loading...