Page MenuHomeFreeBSD

boot/zfs: Extend zfsimpl.h and make it easier to use
ClosedPublic

Authored by markj on May 20 2022, 11:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 25, 3:39 PM
Unknown Object (File)
Fri, Sep 25, 3:38 PM
Unknown Object (File)
Mon, Sep 14, 8:43 AM
Unknown Object (File)
Mon, Sep 14, 8:43 AM
Unknown Object (File)
Mon, Sep 14, 8:37 AM
Unknown Object (File)
Aug 25 2026, 2:31 AM
Unknown Object (File)
Aug 21 2026, 3:39 PM
Unknown Object (File)
Aug 19 2026, 1:21 PM
Subscribers

Details

Summary

Some makefs(8) patches make use of zfsimpl.h (not zfsimpl.c though) to
provide definitions for various on-disk structure. Most of this diff
simply adds new definitions that are useful.

Also reduce dependencies of the header:

  • remove an unused list_node_t field to drop the sys/list.h dependency
  • replace CTASSERT with _Static_assert

And fix the declaration of decode_embedded_bp_compressed().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45656
Build 42544: arc lint + arc unit

Event Timeline

sys/cddl/boot/zfs/zfsimpl.h
560

Could use some verbose message here:)

1916

we are actually not using this structure at all, I think we can just drop it from here.

2066

extern maybe?

markj marked 3 inline comments as done.

Address review feedback

This revision is now accepted and ready to land.May 21 2022, 6:00 PM