Differential D35233

hidraw: Return string lengths for certain ioctls
ClosedPublic
Actions

Authored by grembo on May 17 2022, 9:43 AM.

Tags

None

Referenced Files

	F82883023: D35233.id106096.diff
	Fri, May 3, 1:24 PM

	Unknown Object (File)
	Wed, May 1, 11:10 PM

	Unknown Object (File)
	Wed, May 1, 10:28 PM

	Unknown Object (File)
	Wed, May 1, 9:17 PM

	Unknown Object (File)
	Sun, Apr 28, 4:24 PM

	Unknown Object (File)
	Fri, Apr 26, 7:37 PM

	Unknown Object (File)
	Mar 27 2024, 4:13 PM

	Unknown Object (File)
	Jan 27 2024, 10:03 AM

View All 34 Files

Subscribers

Details

Reviewers

Commits

rGed87ff4e95d9: hidraw: Return string lengths for certain ioctls

Summary

The hidraw(4) driver provides a set of Linux compatible ioctls. Three
of these return the length of the copied string on Linux, but they
always return 0 on FreeBSD:

HIDIOCGRAWPHYS
HIDIOCGRAWNAME
HIDIOCGRAWUNIQ

I noticed this while implementing hidraw(4) support for FreeBSD in
python-fido2[0], so there is some real-world software relying on
this return value (I would assume that this isn't the only one).

This patch aims to fix this by returning the length of the copied
string (including the trailing NUL character) in the affected ioctls.

[0]
https://github.com/Yubico/python-fido2/pull/139
https://github.com/Yubico/python-fido2/blob/master/fido2/hid/linux.py#L63-L74

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45605
Build 42493: arc lint + arc unit

Event Timeline

grembo created this revision.May 17 2022, 9:43 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 17 2022, 9:43 AM

grembo requested review of this revision.May 17 2022, 9:43 AM

Harbormaster completed remote builds in B45605: Diff 106096.May 17 2022, 9:43 AM

grembo edited the summary of this revision. (Show Details)May 17 2022, 9:59 AM

Make strlen calculation behave like on Linux (count trailing NUL)

Harbormaster completed remote builds in B45606: Diff 106097.May 17 2022, 10:34 AM

grembo edited the summary of this revision. (Show Details)May 17 2022, 10:43 AM

LGTM

This revision is now accepted and ready to land.May 17 2022, 9:29 PM

Closed by commit rGed87ff4e95d9: hidraw: Return string lengths for certain ioctls (authored by grembo). · Explain WhyMay 18 2022, 10:14 AM

This revision was automatically updated to reflect the committed changes.

grembo added a commit: rGed87ff4e95d9: hidraw: Return string lengths for certain ioctls.

@wulf Thanks for reviewing

Revision Contents
Changeset List

Path

Size

sys/

dev/

hid/

7 lines

Diff 106096

sys/dev/hid/hidraw.c

Loading...