Page MenuHomeFreeBSD
Differential D4234

Workaround the rare condition in VNIC when the empty fragment is received
AbandonedPublic
Actions

Authored by zbb on Nov 20 2015, 6:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 6, 8:39 AM
Unknown Object (File)
Fri, Jan 3, 10:18 AM
Unknown Object (File)
Mon, Dec 30, 1:11 AM
Unknown Object (File)
Dec 1 2024, 9:59 PM
Unknown Object (File)
Nov 4 2024, 4:45 PM
Unknown Object (File)
Nov 4 2024, 4:45 PM
Unknown Object (File)
Nov 4 2024, 4:45 PM
Unknown Object (File)
Nov 4 2024, 4:22 PM
View All 66 Files
Subscribers
arm64

Details

Reviewers
emaste
imp
wma_semihalf.com
• ian
Summary

Even though HW informs that there are multiple packet fragments received,
the secondary fragment (provided by the descriptor filled-out by HW) may
be empty. This situation will cause driver to call panic. To temporarily
workaround this problem just drop packets that were received in multiple
fragments of which one is empty.

Pointed out by: emaste
Reviewed by:
Obtained from: Semihalf
Differential Revision:

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zbb updated this revision to Diff 10382.Nov 20 2015, 6:48 PM
zbb retitled this revision from to Workaround the rare condition in VNIC when the empty fragment is received.
zbb updated this object.
zbb edited the test plan for this revision. (Show Details)
zbb added reviewers: emaste, imp, • ian.
zbb set the repository for this revision to rS FreeBSD src repository - subversion.
zbb added a reviewer: wma_semihalf.com.
zbb added a subscriber: arm64.
emaste added inline comments.Nov 20 2015, 7:18 PM
sys/dev/vnic/nicvf_queues.c
304–324

Can we extend the comment to provide more background here? Does the hardware report that a packet is available before the 2nd slot is filled in or something like that?

emaste edited edge metadata.Nov 20 2015, 7:19 PM

Overall I think this is a reasonable workaround to allow us to make progress, but the comment should explain more about how this might happen.

zbb updated this revision to Diff 10606.Nov 30 2015, 3:05 PM
zbb edited edge metadata.
zbb removed rS FreeBSD src repository - subversion as the repository for this revision.
wma_semihalf.com edited edge metadata.Dec 1 2015, 11:14 AM

I suggest we add statistics/counters for that particular situation. It'd be good to track it down and check if all hw is prone to this issue or it's only one which Ed was using.

emaste added a comment.Dec 8 2015, 9:23 PM
In D4234#91227, @wma_semihalf.com wrote:

I suggest we add statistics/counters for that particular situation. It'd be good to track it down and check if all hw is prone to this issue or it's only one which Ed was using.

Seems like a good idea -- maybe it's not an issue with 2.0 silicon?

zbb planned changes to this revision.Feb 26 2016, 3:21 PM

Wrong solution.

zbb abandoned this revision.Feb 26 2016, 3:21 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vnic/
33 lines

Diff 10606

View Options

sys/dev/vnic/nicvf_queues.c

Loading...