Differential D35128

fusefs: handle evil servers that return illegal inode numbers
ClosedPublic
Actions

Authored by asomers on May 4 2022, 11:40 PM.

Tags

None

Referenced Files

	F151965240: D35128.id105907.diff
	Sat, Apr 11, 7:57 PM

	F151887594: D35128.id.diff
	Sat, Apr 11, 9:02 AM

	F151847249: D35128.id.diff
	Sat, Apr 11, 1:57 AM

	Unknown Object (File)
	Sun, Apr 5, 11:55 AM

	Unknown Object (File)
	Sat, Apr 4, 2:05 AM

	Unknown Object (File)
	Mon, Mar 23, 4:12 PM

	Unknown Object (File)
	Mon, Mar 23, 12:48 PM

	Unknown Object (File)
	Fri, Mar 20, 6:16 PM

Subscribers

Details

Reviewers

emaste
pfg

Commits

rG93891ed2f794: fusefs: make the mknod.cc tests a bit more general.
rG1f44d1861a01: fusefs: handle evil servers that return illegal inode numbers
rG0bef4927ea85: fusefs: handle evil servers that return illegal inode numbers

Summary

fusefs: handle evil servers that return illegal inode numbers

If during FUSE_CREATE, FUSE_MKDIR, etc the server returns the same inode number for the new file as for its parent directory, reject it. Previously this would triggers a recurse-on-non-recursive lock panic.

If during FUSE_LINK the server returns a different inode number for the new name as for the old one, reject it. Obviously, that can't be a hard link.

If during FUSE_LOOKUP the server returns the same inode number for the new file as for its parent directory, reject it. Nothing good can come of this.

PR: 263662
Reported by: Robert Morris <rtm@lcs.mit.edu>
MFC after: 2 weeks

Test Plan

tests added

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.May 4 2022, 11:40 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 4 2022, 11:40 PM

asomers requested review of this revision.May 4 2022, 11:40 PM

Harbormaster completed remote builds in B45477: Diff 105695.May 4 2022, 11:40 PM

LGTM

This revision is now accepted and ready to land.May 12 2022, 12:38 AM

Closed by commit rG0bef4927ea85: fusefs: handle evil servers that return illegal inode numbers (authored by asomers). · Explain WhyMay 12 2022, 8:33 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG0bef4927ea85: fusefs: handle evil servers that return illegal inode numbers.

asomers added a commit: rG1f44d1861a01: fusefs: handle evil servers that return illegal inode numbers.Jun 18 2022, 2:17 PM

asomers added a commit: rG93891ed2f794: fusefs: make the mknod.cc tests a bit more general..Aug 20 2022, 2:56 AM

Revision Contents
Changeset List

Path

Size

sys/

fs/

fuse/

1 line

6 lines

27 lines

tests/

sys/

fs/

fusefs/

41 lines

47 lines

31 lines

53 lines

32 lines

22 lines

Diff 105907

sys/fs/fuse/fuse_ipc.h

Loading...

sys/fs/fuse/fuse_node.c

Loading...

sys/fs/fuse/fuse_vnops.c

Loading...

tests/sys/fs/fusefs/create.cc

Loading...

tests/sys/fs/fusefs/link.cc

Loading...

tests/sys/fs/fusefs/lookup.cc

Loading...

tests/sys/fs/fusefs/mkdir.cc

Loading...

tests/sys/fs/fusefs/mknod.cc

Loading...

tests/sys/fs/fusefs/symlink.cc

Loading...