In D35031#794208, @salvadore wrote:

I have applied all suggested and requested changes.

@sunpoet: Could you please explain better why json >= 1.6.5, ~> 1.6 should be converted to rubygem-json>=1.6.5<2? According to my understanding of the ~> symbol I would have thought it should be converted to rubygem-json>=1.6.5<1.7.

">= 1.6.5" converts to ">= 1.6.5".
"~> 1.6" converts to ">=1.6<2".
Therefore, the intersection would be ">=1.6.5<2"

Reference: https://guides.rubygems.org/patterns/

In D35031#795227, @sunpoet wrote:

In D35031#794208, @salvadore wrote:

I have applied all suggested and requested changes.

@sunpoet: Could you please explain better why json >= 1.6.5, ~> 1.6 should be converted to rubygem-json>=1.6.5<2? According to my understanding of the ~> symbol I would have thought it should be converted to rubygem-json>=1.6.5<1.7.

">= 1.6.5" converts to ">= 1.6.5".
"~> 1.6" converts to ">=1.6<2".
Therefore, the intersection would be ">=1.6.5<2"

Reference: https://guides.rubygems.org/patterns/

Ah, right, I understand now. Thanks.

As for the review, is it fine now? Does it have ruby approval or does it need some more fix?

In D35031#795684, @salvadore wrote:

@sunpoet: I am sorry, but before committing I tested the port again and the build now fails. This is due to the dependency on rubygem-json>=1.6.5<2: in ports we have rubygem-json version 2.5.1.

Then I removed "<2". I tested and I confirm that the other port that I am trying to create and depends on rubygem-docopt works as expected ( https://reviews.freebsd.org/D35032 ), so I think rubygem-docopt works well with rubygem-json version 2.5.1.
I also plan to suggest upstream to update their dependency.

Is the review still accepted? Should I solve the problem with a different strategy?

Thanks.

I just noticed that it is a development dependency. Does it builds fine without rubygem-json (either 1.x or 2.x)? If so, please remove the BUILD_DEPENDS.