- Update to 6.0.3
- Remove unneeded dependency on GCC, fixing [1]
- Style improvements
- Adopt
PR: 263541 [1]
Details
Details
- Reviewers
gerald tcberner - Commits
- R11:c768cdd4fe7d: science/massxpert: Update to 6.0.3 and adopt
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 45387 Build 42275: arc lint + arc unit
Event Timeline
Comment Actions
Wow, from 3.6.1 to 6.0.3? That port really was abandoned.
Nice work!
And, ah so nice to see USE_GCC dropped. :-) Thanks!
| science/massxpert/Makefile | ||
|---|---|---|
| 26–28 | ^ I would do the line break prior to buildtools_build -- that way you nicely split run/build and build-deps. | |
| science/massxpert/Makefile | ||
|---|---|---|
| 26–28 | Thanks for your advice, unfortunately it arrived after gerald's approval and my commit. I prefer to leave the break where it is: on a hand, the list is short enough that separating different kinds of dependencies is not essential in my opinion; on the other hand I let choosing portfmt where to break the line. I prefer to avoid as much as possible making exceptions to portfmt suggestions: the more exceptions I make, the harder it is to use portfmt to maintain style consistency in the future. However, if you have a strong preference to break the line prior to buildtools_build, just tell me and I will take a note to move this line break with the next commit I make on this file. | |
Comment Actions
Keep up the good work! :-)
| science/massxpert/Makefile | ||
|---|---|---|
| 17–18 | Are you sure libpcre is a requirement? I can't find any reference in source and Debian doesn't list as a reqirement along a few other libs (please verify) | |
| 20 | ||
Comment Actions
Thanks diizzy for your review. Since this revision had already been committed, I opened a new one to address your comments:
https://reviews.freebsd.org/D35138