science/massxpert: Update to 6.0.3 and adopt

[salvadore]

Summary

• Update to 6.0.3
• Remove unneeded dependency on GCC, fixing [1]
• Style improvements
• Adopt

PR: 263541 [1]

[gerald]

Wow, from 3.6.1 to 6.0.3? That port really was abandoned.

Nice work!

And, ah so nice to see USE_GCC dropped. :-) Thanks!

[tcberner]

science/massxpert/Makefile

26

^ I would do the line break prior to buildtools_build -- that way you nicely split run/build and build-deps.

[salvadore]

science/massxpert/Makefile

26

Thanks for your advice, unfortunately it arrived after gerald's approval and my commit.

I prefer to leave the break where it is: on a hand, the list is short enough that separating different kinds of dependencies is not essential in my opinion; on the other hand I let choosing portfmt where to break the line. I prefer to avoid as much as possible making exceptions to portfmt suggestions: the more exceptions I make, the harder it is to use portfmt to maintain style consistency in the future.

However, if you have a strong preference to break the line prior to buildtools_build, just tell me and I will take a note to move this line break with the next commit I make on this file.

[diizzy]

Keep up the good work! :-)

science/massxpert/Makefile

17

Are you sure libpcre is a requirement? I can't find any reference in source and Debian doesn't list as a reqirement along a few other libs (please verify)
https://salsa.debian.org/debichem-team/massxpert/-/blob/master/debian/control

20

https://salsa.debian.org/debichem-team/massxpert/-/blob/master/CMakeLists.txt#L64
https://cgit-beta.freebsd.org/ports/tree/Mk/Uses/compiler.mk#n12
You probably want to define this

[salvadore]

In D35072#795346, @diizzy wrote:

Keep up the good work! :-)

Thanks diizzy for your review. Since this revision had already been committed, I opened a new one to address your comments:
https://reviews.freebsd.org/D35138