Differential D34909

vm: Move the "vm_wait in early boot" assertion to the proper place
ClosedPublic
Actions

Authored by markj on Apr 14 2022, 1:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 15 2025, 3:18 AM

	Unknown Object (File)
	Dec 10 2025, 1:27 AM

	Unknown Object (File)
	Dec 8 2025, 11:55 AM

	Unknown Object (File)
	Dec 6 2025, 6:14 PM

	Unknown Object (File)
	Dec 2 2025, 5:54 PM

	Unknown Object (File)
	Nov 28 2025, 9:13 PM

	Unknown Object (File)
	Nov 20 2025, 5:05 PM

	Unknown Object (File)
	Nov 20 2025, 5:03 PM

Subscribers

Details

Reviewers

kib
alc

Commits

rG6fb7c42d593d: vm: Move the "vm_wait in early boot" assertion to the proper place

Summary

The assertion was added in commit 1771e987ca6a. After that, vm_wait()
and friends were refactored such that the actual sleep happens
elsewhere. Now the assertion condition is not checked when
vm_wait_doms() is called directly, and it is checked even if we are not
going to sleep (because vm_page_count_min_set(wdoms) is false).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45158
Build 42046: arc lint + arc unit

Event Timeline

markj created this revision.Apr 14 2022, 1:21 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 14 2022, 1:21 PM

markj requested review of this revision.Apr 14 2022, 1:21 PM

Harbormaster completed remote builds in B45158: Diff 104993.Apr 14 2022, 1:21 PM

kib accepted this revision.Apr 14 2022, 2:29 PM

This revision is now accepted and ready to land.Apr 14 2022, 2:29 PM

alc accepted this revision.Apr 14 2022, 4:17 PM

alc added inline comments.

sys/vm/vm_page.c
3243	As an aside, this variable seems pointless. Each of the 3 cases could end in a return statement.

Closed by commit rG6fb7c42d593d: vm: Move the "vm_wait in early boot" assertion to the proper place (authored by markj). · Explain WhyApr 14 2022, 7:49 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG6fb7c42d593d: vm: Move the "vm_wait in early boot" assertion to the proper place.

Revision Contents
Changeset List

Path

Size

sys/

vm/

4 lines

Diff 104993

sys/vm/vm_page.c

Loading...