Page MenuHomeFreeBSD

gbde: stop rebuilding sha512 bits
ClosedPublic

Authored by kevans on Mar 25 2022, 1:57 AM.
Tags
None
Referenced Files
F140809441: D34668.id121056.diff
Sun, Dec 28, 8:01 AM
Unknown Object (File)
Thu, Dec 11, 5:35 AM
Unknown Object (File)
Tue, Dec 9, 8:29 AM
Unknown Object (File)
Mon, Dec 8, 3:43 AM
Unknown Object (File)
Nov 25 2025, 9:24 PM
Unknown Object (File)
Nov 23 2025, 4:58 AM
Unknown Object (File)
Nov 23 2025, 4:58 AM
Unknown Object (File)
Nov 23 2025, 4:53 AM
Subscribers

Details

Summary

In the early days of gbde, it linked against libmd. Shortly after
conception, phk replaced ARC4 with SHA-512, but libmd did not have SHA2
at the time thus he built a copy of sha2.c for gbde.

Fast forward 3 years, cperciva adds SHA2 to libmd -- this makes gbde's
build of sha2.c redundant, but it's (understandably) overlooked. Let's
simplify the gbde build now and just assume that libmd includes the most
optimal implementation.

Reported by: koobs (weird lto errors?)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44886
Build 41774: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 26 2023, 5:37 AM
This revision was automatically updated to reflect the committed changes.