Page MenuHomeFreeBSD
Differential D34591

mixer(8): remove [.volume] string from default printout
ClosedPublic
Actions

Authored by christos on Mar 17 2022, 5:18 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Jul 19, 5:50 PM
Unknown Object (File)
Thu, Jul 2, 8:00 AM
Unknown Object (File)
Tue, Jun 30, 7:31 AM
Unknown Object (File)
Mon, Jun 29, 1:07 AM
Unknown Object (File)
Sun, Jun 28, 4:26 PM
Unknown Object (File)
Thu, Jun 25, 2:27 PM
Unknown Object (File)
Wed, Jun 24, 12:55 AM
Unknown Object (File)
Jun 21 2026, 8:38 PM
View All Files
Subscribers
imp

Details

Reviewers
• hselasky
Commits
rG60bdfe986968: mixer(8): Remove [.volume] string from default printout.
Summary

Printing [.volume] is redundant. Feel free to play with the spaces inside printf.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Mar 17 2022, 5:18 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 17 2022, 5:18 PM
christos requested review of this revision.Mar 17 2022, 5:18 PM
• hselasky accepted this revision.Mar 17 2022, 5:32 PM

Looks good. Are there more patches coming?

This revision is now accepted and ready to land.Mar 17 2022, 5:32 PM
christos added a comment.Mar 17 2022, 5:34 PM
In D34591#783694, @hselasky wrote:

Looks good. Are there more patches coming?

If we agree on implementing mixer vol=N yes, but I'm not sure I'll do it today.

christos added a child revision: D34612: mixer(8): add shorthand syntax for setting the volume.Mar 20 2022, 4:05 PM
christos added a comment.Mar 20 2022, 4:07 PM

D34612 depends on this revision.

christos added a child revision: D34613: mixer(8): move control defines into an enum.Mar 20 2022, 4:27 PM
Closed by commit rG60bdfe986968: mixer(8): Remove [.volume] string from default printout. (authored by • hselasky). · Explain WhyMar 20 2022, 4:34 PM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rG60bdfe986968: mixer(8): Remove [.volume] string from default printout..

Revision Contents
Changeset List

PathSize
usr.sbin/
mixer/
8 lines

Diff 104031

View Options

usr.sbin/mixer/mixer.c

Loading...