Paths

Table of Contentst

Differential D34591

mixer(8): remove [.volume] string from default printout
ClosedPublic
Actions

Authored by christos on Mar 17 2022, 5:18 PM.

Tags

Referenced Files

	Unknown Object (File)
	Fri, Jan 17, 11:52 PM

	Unknown Object (File)
	Dec 16 2024, 11:01 AM

	Unknown Object (File)
	Dec 6 2024, 2:08 AM

	Unknown Object (File)
	Nov 24 2024, 11:07 PM

	Unknown Object (File)
	Nov 24 2024, 9:21 PM

	Unknown Object (File)
	Nov 20 2024, 3:52 AM

	Unknown Object (File)
	Nov 19 2024, 3:13 PM

	Unknown Object (File)
	Nov 19 2024, 9:08 AM

View All 61 Files

Subscribers

Details

Reviewers

Commits

rG60bdfe986968: mixer(8): Remove [.volume] string from default printout.

Summary

Printing [.volume] is redundant. Feel free to play with the spaces inside printf.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Mar 17 2022, 5:18 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 17 2022, 5:18 PM

christos requested review of this revision.Mar 17 2022, 5:18 PM

Looks good. Are there more patches coming?

This revision is now accepted and ready to land.Mar 17 2022, 5:32 PM

In D34591#783694, @hselasky wrote:

Looks good. Are there more patches coming?

If we agree on implementing mixer vol=N yes, but I'm not sure I'll do it today.

christos added a child revision: D34612: mixer(8): add shorthand syntax for setting the volume.Mar 20 2022, 4:05 PM

D34612 depends on this revision.

christos added a child revision: D34613: mixer(8): move control defines into an enum.Mar 20 2022, 4:27 PM

Closed by commit rG60bdfe986968: mixer(8): Remove [.volume] string from default printout. (authored by • hselasky). · Explain WhyMar 20 2022, 4:34 PM

This revision was automatically updated to reflect the committed changes.

• hselasky added a commit: rG60bdfe986968: mixer(8): Remove [.volume] string from default printout..

Revision Contents
Changeset List

Path

Size

usr.sbin/

mixer/

8 lines

Diff 104031

usr.sbin/mixer/mixer.c

Loading...