Page MenuHomeFreeBSD
Differential D34591

mixer(8): remove [.volume] string from default printout
ClosedPublic
Actions

Authored by christos on Mar 17 2022, 5:18 PM.
Tags
Referenced Files
Unknown Object (File)
Thu, May 23, 4:07 AM
Unknown Object (File)
Mon, May 13, 1:50 PM
Unknown Object (File)
Apr 19 2024, 12:05 AM
Unknown Object (File)
Mar 22 2024, 3:49 PM
Unknown Object (File)
Mar 22 2024, 3:49 PM
Unknown Object (File)
Mar 8 2024, 5:58 PM
Unknown Object (File)
Mar 8 2024, 5:48 PM
Unknown Object (File)
Feb 6 2024, 2:25 AM
View All 35 Files
Subscribers
imp

Details

Reviewers
• hselasky
Commits
rG60bdfe986968: mixer(8): Remove [.volume] string from default printout.
Summary

Printing [.volume] is redundant. Feel free to play with the spaces inside printf.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

christos created this revision.Mar 17 2022, 5:18 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 17 2022, 5:18 PM
christos requested review of this revision.Mar 17 2022, 5:18 PM
• hselasky accepted this revision.Mar 17 2022, 5:32 PM

Looks good. Are there more patches coming?

This revision is now accepted and ready to land.Mar 17 2022, 5:32 PM
christos added a comment.Mar 17 2022, 5:34 PM
In D34591#783694, @hselasky wrote:

Looks good. Are there more patches coming?

If we agree on implementing mixer vol=N yes, but I'm not sure I'll do it today.

christos added a child revision: D34612: mixer(8): add shorthand syntax for setting the volume.Mar 20 2022, 4:05 PM
christos added a comment.Mar 20 2022, 4:07 PM

D34612 depends on this revision.

christos added a child revision: D34613: mixer(8): move control defines into an enum.Mar 20 2022, 4:27 PM
Closed by commit rG60bdfe986968: mixer(8): Remove [.volume] string from default printout. (authored by • hselasky). · Explain WhyMar 20 2022, 4:34 PM
This revision was automatically updated to reflect the committed changes.
• hselasky added a commit: rG60bdfe986968: mixer(8): Remove [.volume] string from default printout..

Revision Contents
Changeset List

PathSize
usr.sbin/
mixer/
8 lines

Diff 103953

View Options

usr.sbin/mixer/mixer.c

Loading...