Page MenuHomeFreeBSD
Differential D34550

bsnmp: Use mkstemp when creating clients local socket
ClosedPublic
Actions

Authored by thj on Mar 14 2022, 3:39 PM.
Tags
None
Referenced Files
F164581662: D34550.id103828.diff
Sun, Aug 2, 4:59 AM
F164544877: D34550.id103866.diff
Sun, Aug 2, 12:45 AM
Unknown Object (File)
Sat, Aug 1, 9:59 PM
Unknown Object (File)
Sat, Aug 1, 7:46 AM
Unknown Object (File)
Fri, Jul 31, 8:04 PM
Unknown Object (File)
Thu, Jul 30, 9:12 AM
Unknown Object (File)
Wed, Jul 29, 1:07 AM
Unknown Object (File)
Sun, Jul 26, 6:25 PM
View All Files
Subscribers
imp

Details

Reviewers
harti
rew
Group Reviewers
Klara
Commits
rG81e0e7b9e36d: bsnmp: Use mkstemp when creating clients local socket

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 44764
Build 41652: arc lint + arc unit

Event Timeline

thj created this revision.Mar 14 2022, 3:39 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 14 2022, 3:39 PM
thj requested review of this revision.Mar 14 2022, 3:39 PM
Harbormaster completed remote builds in B44764: Diff 103828.Mar 14 2022, 3:39 PM
thj added a comment.Mar 14 2022, 3:41 PM

I am not sure if FreeBSD is upstream here, it might be harti's own private tree, it isn't 100% clear to me.

I have created this review as a place for discussion if we need it.

harti accepted this revision.Mar 14 2022, 6:03 PM

Looks good to me.

Yes, upstream is currently a private repo which I plan to make public later this year when I have v2 in a working condition. I normally fetch all modifications from the FreeBSD tree and put them into that repo.

This revision is now accepted and ready to land.Mar 14 2022, 6:03 PM
rew accepted this revision.Mar 14 2022, 6:32 PM
Closed by commit rG81e0e7b9e36d: bsnmp: Use mkstemp when creating clients local socket (authored by thj). · Explain WhyMar 15 2022, 8:21 AM
This revision was automatically updated to reflect the committed changes.
thj added a commit: rG81e0e7b9e36d: bsnmp: Use mkstemp when creating clients local socket.
glebius added a reverting change: D51031: libbsnmp: fix local client socket creation.Jun 25 2025, 2:17 AM
glebius mentioned this in D51031: libbsnmp: fix local client socket creation.Jun 25 2025, 2:18 AM
glebius added a reverting change: rGd4f042f094ec: libbsnmp: fix local client socket creation.Jul 17 2025, 3:59 PM

Revision Contents
Changeset List

PathSize
contrib/
bsnmp/
lib/
2 lines

Diff 103828

View Options

contrib/bsnmp/lib/snmpclient.c

Loading...