Page MenuHomeFreeBSD
Differential D34441

amd64: Call clock_init() after finishidentcpu()
AbandonedPublic
Actions

Authored by khng on Mar 4 2022, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 17, 12:54 PM
Unknown Object (File)
Fri, Aug 8, 8:58 PM
Unknown Object (File)
Jul 20 2025, 11:53 AM
Unknown Object (File)
Jun 24 2025, 4:16 AM
Unknown Object (File)
Jun 21 2025, 12:34 PM
Unknown Object (File)
Jun 21 2025, 12:18 PM
Unknown Object (File)
Jun 21 2025, 8:25 AM
Unknown Object (File)
Jun 13 2025, 11:01 PM
View All 54 Files
Subscribers
imp

Details

Reviewers
markj
Summary

In a subsequent commit clock_init() will attempt to determine the TSC
frequency, and this requires that CPU identification is finalized.

MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44656
Build 41544: arc lint + arc unit

Event Timeline

khng created this revision.Mar 4 2022, 5:08 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 4 2022, 5:08 PM
khng requested review of this revision.Mar 4 2022, 5:08 PM
Harbormaster completed remote builds in B44656: Diff 103495.Mar 4 2022, 5:08 PM
markj accepted this revision.Mar 4 2022, 6:34 PM

In a subsequent commit clock_init() will attempt to determine the TSC frequency, and this requires that CPU identification is finalized.

Need to remove "In a subsequent commit" and change "will attempt" to "attempts".

sys/amd64/amd64/machdep.c
1456

A more conservative approach is to move the clock_init() call instead, but ok.

This revision is now accepted and ready to land.Mar 4 2022, 6:34 PM
khng abandoned this revision.Mar 4 2022, 6:41 PM

Superseded by https://reviews.freebsd.org/D34444.

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
3 lines

Diff 103495

View Options

sys/amd64/amd64/machdep.c

Loading...