Page MenuHomeFreeBSD
Differential D34423

ocs_fc: Do not respond to unsolicited NOP BLS command.
ClosedPublic
Actions

Authored by ram on Mar 3 2022, 12:56 PM.
Tags
None
Referenced Files
F105535907: D34423.id103431.diff
Tue, Dec 17, 9:36 AM
F105535831: D34423.id103480.diff
Tue, Dec 17, 9:35 AM
F105526042: D34423.diff
Tue, Dec 17, 6:59 AM
Unknown Object (File)
Thu, Dec 12, 4:55 AM
Unknown Object (File)
Tue, Nov 26, 7:31 AM
Unknown Object (File)
Fri, Nov 22, 7:59 AM
Unknown Object (File)
Fri, Nov 22, 7:58 AM
Unknown Object (File)
Fri, Nov 22, 7:58 AM
View All 67 Files
Subscribers
imp

Details

Reviewers
ken
mav
Commits
rG4a90d6c823df: ocs_fc: Do not respond to unsolicited NOP BLS command.
rG6e71c95f11d1: ocs_fc: Do not respond to unsolicited NOP BLS command.
rG57e4b677559a: ocs_fc: Do not respond to unsolicited NOP BLS command.
Summary

Drop unsolicited BLS commands other than ABTS.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44627
Build 41515: arc lint + arc unit

Event Timeline

ram created this revision.Mar 3 2022, 12:56 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 3 2022, 12:57 PM
ram requested review of this revision.Mar 3 2022, 12:57 PM
Harbormaster completed remote builds in B44627: Diff 103431.Mar 3 2022, 12:57 PM
mav accepted this revision.Mar 3 2022, 4:01 PM

It makes some sense to me. I suppose other cases could be NOP and BA_ACC/BA_REJ, which do not require action if unsolicited. I just guess incoming BA_* for outgoing ABTS are handled somewhere else, if they reach the driver at all.

This revision is now accepted and ready to land.Mar 3 2022, 4:01 PM
ram added a comment.Mar 3 2022, 4:06 PM
In D34423#779963, @mav wrote:

It makes some sense to me. I suppose other cases could be NOP and BA_ACC/BA_REJ, which do not require action if unsolicited. I just guess incoming BA_* for outgoing ABTS are handled somewhere else, if they reach the driver at all.

Yes, the ABTS response will be handled by corresponding WQE.

Closed by commit rG57e4b677559a: ocs_fc: Do not respond to unsolicited NOP BLS command. (authored by Ram Kishore Vegesna <ram@FreeBSD.org>). · Explain WhyMar 4 2022, 4:57 AM
This revision was automatically updated to reflect the committed changes.
Ram Kishore Vegesna <ram@FreeBSD.org> added a commit: rG57e4b677559a: ocs_fc: Do not respond to unsolicited NOP BLS command..
Ram Kishore Vegesna <ram@FreeBSD.org> added a commit: rG6e71c95f11d1: ocs_fc: Do not respond to unsolicited NOP BLS command..Mar 7 2022, 11:01 AM
Ram Kishore Vegesna <ram@FreeBSD.org> added a commit: rG4a90d6c823df: ocs_fc: Do not respond to unsolicited NOP BLS command..Mar 7 2022, 11:03 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
ocs_fc/
2 lines

Diff 103431

View Options

sys/dev/ocs_fc/ocs_unsol.c

Loading...