Page MenuHomeFreeBSD
Differential D28456

sysutils/u-boot-pinebookpro: Patch for working display.
Needs ReviewPublic
Actions

Authored by jsm on Feb 2 2021, 2:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 11:37 AM
Unknown Object (File)
Nov 21 2024, 9:07 AM
Unknown Object (File)
Oct 2 2024, 11:59 PM
Unknown Object (File)
Oct 2 2024, 8:24 AM
Unknown Object (File)
Sep 6 2024, 1:57 AM
Unknown Object (File)
Sep 5 2024, 11:27 AM
Unknown Object (File)
Sep 5 2024, 8:01 AM
Unknown Object (File)
Sep 4 2024, 6:47 PM
View All 58 Files
Subscribers
andrew
mat

Details

Reviewers
s199p.wa1k9r_mail.ru
manu
Summary

Reset display in u-boot

Test Plan

Builds in poudriere, works on pinebook pro.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jsm created this revision.Feb 2 2021, 2:52 AM
Herald added a subscriber: mat. · View Herald TranscriptFeb 2 2021, 2:52 AM
jsm requested review of this revision.Feb 2 2021, 2:52 AM
jsm added a reviewer: manu.Feb 2 2021, 2:55 AM
manu requested changes to this revision.Feb 3 2021, 9:18 AM

I really don't like to have a lot of big patches in ports for u-boot.
It's annoying when upstream changes and I have to rewrites the patches.
I suggest you start by upstreaming those changes in u-boot.
Thanks.

This revision now requires changes to proceed.Feb 3 2021, 9:18 AM
jsm added a comment.Feb 5 2021, 5:38 PM

FYI see https://people.freebsd.org/~jsm/u-boot-master.diff for a diff against master.
I had to revert upstreams 0a2aaab0b678fd1778ff2fc59d0770fc8299553 (done in above diff).
I will try to work with upstream.
Thanks
/Jesper

jsm added a comment.Feb 28 2021, 3:36 PM

FYI
upstream patch proposal
Does not include down clocking the ACLK_VOP1 so we still loses screen. But a panfrost driver should be in the makings source : https://twitter.com/onewilshire/status/1363792441871073280
Also note that the patches in the ports tree for cmd/elf.c and common/bootm.c are still necessary otherwise the boot process hangs.

manu added a comment.Mar 2 2021, 3:13 PM
In D28456#648865, @jsm wrote:

FYI
upstream patch proposal

You will likely not receive any response for this patch.
It isn't splitted in different commits and maintainers aren't in to or cc.

Does not include down clocking the ACLK_VOP1 so we still loses screen. But a panfrost driver should be in the makings source : https://twitter.com/onewilshire/status/1363792441871073280

Panfrost is only the GPU, prior to that a DRM driver for the display engine is needed.

Also note that the patches in the ports tree for cmd/elf.c and common/bootm.c are still necessary otherwise the boot process hangs.

manu added a comment.Mar 5 2021, 10:40 AM

There is a new serie for eDP support on rk3399 : https://patchwork.ozlabs.org/project/uboot/list/?series=232334
I haven't tested it yet.

jsm added a comment.Mar 5 2021, 6:54 PM

I've tested with the series and display works. We of course still loose display when the kernel boots.
See https://people.freebsd.org/~jsm/u-boot-pinebookpro/ for a build and a combined patch. (6a026e5649f00c0b157a935279dfd625889db675.diff)

manu added a comment.Mar 5 2021, 7:09 PM
In D28456#651630, @jsm wrote:

I've tested with the series and display works. We of course still loose display when the kernel boots.
See https://people.freebsd.org/~jsm/u-boot-pinebookpro/ for a build and a combined patch. (6a026e5649f00c0b157a935279dfd625889db675.diff)

Please use PATCHFILES in the port makefile with the patchwork IDs.

jsm updated this revision to Diff 85250.Mar 5 2021, 11:03 PM

Take the libefi patch that enables read of last block the edp series and a usb config patch for keyboard to work.

manu requested changes to this revision.Jul 22 2021, 4:27 PM

Can you rebase onto main please ?

This revision now requires changes to proceed.Jul 22 2021, 4:27 PM
jsm updated this revision to Diff 92665.Jul 22 2021, 7:39 PM
jsm edited the summary of this revision. (Show Details)
jsm edited the test plan for this revision. (Show Details)

rebased to new u-boot-master.

Herald added a subscriber: andrew. · View Herald TranscriptJul 22 2021, 7:39 PM
manu added inline comments.Jul 22 2021, 7:45 PM
sysutils/u-boot-pinebookpro/files/patch-arch_arm_dts_rk3399-pinebook-pro.dts
8 ↗(On Diff #92665)

What is the problem with this regulator ?

jsm added inline comments.Jul 22 2021, 7:48 PM
sysutils/u-boot-pinebookpro/files/patch-arch_arm_dts_rk3399-pinebook-pro.dts
8 ↗(On Diff #92665)

When regulator-always-on is set, the Pinebook Pro looses display on warm reboot e.g init 6.

jsm added a comment.Feb 13 2022, 2:22 PM

The frequency part is obsolete, but perhaps we could consider this work from NetBSD https://github.com/NetBSD/pkgsrc/blob/trunk/sysutils/u-boot/patches-2021.07/patch-board_pine64_pinebook-pro-rk3399_pinebook-pro-rk3399.c

jsm updated this revision to Diff 102750.Feb 14 2022, 5:20 PM
jsm retitled this revision from sysutils/u-boot-pinebookpro: Patches for working display. to sysutils/u-boot-pinebookpro: Patch for working display. .
jsm edited the summary of this revision. (Show Details)
jsm edited the test plan for this revision. (Show Details)

Change to more recent situation, taken from netbsd. The display does not work correctly on warm reboot

manu added a comment.Feb 15 2022, 1:19 PM

I'd really love to not have patches in u-boot ports so please upstream the needed changes.

manu resigned from this revision.Dec 25 2023, 5:01 PM

Almost two years without update, resigning.

Revision Contents
Changeset List

PathSize
sysutils/
u-boot-pinebookpro/
3 lines
files/
39 lines

Diff 102750

View Options

sysutils/u-boot-pinebookpro/Makefile

Loading...
View Options

sysutils/u-boot-pinebookpro/files/patch-board_pine64_pinebook-pro-rk3399_pinebook-pro-rk3399.c

Loading...