sysutils/u-boot-pinebookpro: Patch for working display.

[jsm]

Summary

Reset display in u-boot

Test Plan

Builds in poudriere, works on pinebook pro.

[manu]

I really don't like to have a lot of big patches in ports for u-boot.
It's annoying when upstream changes and I have to rewrites the patches.
I suggest you start by upstreaming those changes in u-boot.
Thanks.

[jsm]

FYI see https://people.freebsd.org/~jsm/u-boot-master.diff for a diff against master.
I had to revert upstreams 0a2aaab0b678fd1778ff2fc59d0770fc8299553 (done in above diff).
I will try to work with upstream.
Thanks
/Jesper

[jsm]

FYI
upstream patch proposal
Does not include down clocking the ACLK_VOP1 so we still loses screen. But a panfrost driver should be in the makings source : https://twitter.com/onewilshire/status/1363792441871073280
Also note that the patches in the ports tree for cmd/elf.c and common/bootm.c are still necessary otherwise the boot process hangs.

[manu]

In D28456#648865, @jsm wrote:

FYI
upstream patch proposal

You will likely not receive any response for this patch.
It isn't splitted in different commits and maintainers aren't in to or cc.

Does not include down clocking the ACLK_VOP1 so we still loses screen. But a panfrost driver should be in the makings source : https://twitter.com/onewilshire/status/1363792441871073280

Panfrost is only the GPU, prior to that a DRM driver for the display engine is needed.

Also note that the patches in the ports tree for cmd/elf.c and common/bootm.c are still necessary otherwise the boot process hangs.

[manu]

There is a new serie for eDP support on rk3399 : https://patchwork.ozlabs.org/project/uboot/list/?series=232334
I haven't tested it yet.

[jsm]

I've tested with the series and display works. We of course still loose display when the kernel boots.
See https://people.freebsd.org/~jsm/u-boot-pinebookpro/ for a build and a combined patch. (6a026e5649f00c0b157a935279dfd625889db675.diff)

[manu]

In D28456#651630, @jsm wrote:

I've tested with the series and display works. We of course still loose display when the kernel boots.
See https://people.freebsd.org/~jsm/u-boot-pinebookpro/ for a build and a combined patch. (6a026e5649f00c0b157a935279dfd625889db675.diff)

Please use PATCHFILES in the port makefile with the patchwork IDs.

[jsm]

Take the libefi patch that enables read of last block the edp series and a usb config patch for keyboard to work.

[manu]

Can you rebase onto main please ?

[jsm]

rebased to new u-boot-master.

[manu]

sysutils/u-boot-pinebookpro/files/patch-arch_arm_dts_rk3399-pinebook-pro.dts

8 ↗

(On Diff #92665)

What is the problem with this regulator ?

[jsm]

sysutils/u-boot-pinebookpro/files/patch-arch_arm_dts_rk3399-pinebook-pro.dts

8 ↗

(On Diff #92665)

When regulator-always-on is set, the Pinebook Pro looses display on warm reboot e.g init 6.

[jsm]

The frequency part is obsolete, but perhaps we could consider this work from NetBSD https://github.com/NetBSD/pkgsrc/blob/trunk/sysutils/u-boot/patches-2021.07/patch-board_pine64_pinebook-pro-rk3399_pinebook-pro-rk3399.c

[jsm]

Change to more recent situation, taken from netbsd. The display does not work correctly on warm reboot

[manu]

I'd really love to not have patches in u-boot ports so please upstream the needed changes.

[manu]

Almost two years without update, resigning.