LinuxKPI: lockdep add lockdep_assert_not_held()
ClosedPublic
Actions

Authored by bz on Feb 9 2022, 12:04 PM.

Details

Reviewers

Group Reviewers

Commits

rGa108252a712a: LinuxKPI: lockdep add lockdep_assert_not_held()
rG064c110f4b55: LinuxKPI: lockdep add lockdep_assert_not_held()

Summary

Add lockdep_assert_not_held() asserting LA_UNLOCKED as needed by a
driver.

MFC after: 3 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44379
Build 41267: arc lint + arc unit

Event Timeline

bz created this revision.Feb 9 2022, 12:04 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 9 2022, 12:04 PM

bz requested review of this revision.Feb 9 2022, 12:04 PM

Harbormaster completed remote builds in B44379: Diff 102562.Feb 9 2022, 12:04 PM

Looks good.

FYI: Beware that Linux sometimes put different meaning into the word held, like any process has locked mutex and not only calling process like in FreeBSD.

In D34232#774433, @hselasky wrote:

Looks good.

Is that an accept?

FYI: Beware that Linux sometimes put different meaning into the word held, like any process has locked mutex and not only calling process like in FreeBSD.

Thanks for the hint. I am thankful for the reviews as they catch these things and I learn. Thank you!

@hselasky can I take the "Looks good" as an accept?

• hselasky accepted this revision.Feb 15 2022, 8:54 AM

This revision is now accepted and ready to land.Feb 15 2022, 8:54 AM

Closed by commit rG064c110f4b55: LinuxKPI: lockdep add lockdep_assert_not_held() (authored by bz). · Explain WhyFeb 15 2022, 11:16 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG064c110f4b55: LinuxKPI: lockdep add lockdep_assert_not_held().

bz added a commit: rGa108252a712a: LinuxKPI: lockdep add lockdep_assert_not_held().Feb 20 2022, 6:16 PM