ufs, msdosfs: do not record witness order when creating vnode
ClosedPublic
Actions

Authored by kib on Feb 1 2022, 5:20 AM.

Tags

None

Referenced Files

	F156848738: D34126.id102210.diff
	Sat, May 16, 9:35 PM

	F156848686: D34126.id102202.diff
	Sat, May 16, 9:35 PM

	F156847650: D34126.diff
	Sat, May 16, 9:24 PM

	Unknown Object (File)
	Thu, May 14, 1:16 PM

	Unknown Object (File)
	Sun, May 10, 10:59 AM

	Unknown Object (File)
	Fri, May 8, 7:03 PM

	Unknown Object (File)
	Thu, May 7, 6:11 AM

	Unknown Object (File)
	Wed, May 6, 6:56 AM

View All Files

Subscribers

imp

Details

Reviewers

mckusick
markj

Commits

rG303d3ae7e841: ufs, msdosfs: do not record witness order when creating vnode
rGd51b0786a2f6: msdosfs_denode.c: some style

Summary

When allocating new vnode, we need to lock it exclusively before
making it externally visible.  Since other threads cannot observe the
vnode yet, current lock order cannot create LoR conditions.

msdosfs_denode.c: some style

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Feb 1 2022, 5:20 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 1 2022, 5:20 AM

kib requested review of this revision.Feb 1 2022, 5:20 AM

I agree with this change.

This revision is now accepted and ready to land.Feb 1 2022, 7:38 AM

Closed by commit rGd51b0786a2f6: msdosfs_denode.c: some style (authored by kib). · Explain WhyFeb 1 2022, 9:03 AM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGd51b0786a2f6: msdosfs_denode.c: some style.

kib added a commit: rG303d3ae7e841: ufs, msdosfs: do not record witness order when creating vnode.

Revision Contents
Changeset List

Path

Size

sys/

fs/

msdosfs/

msdosfs_denode.c

10 lines

Diff 102210

View Options

sys/fs/msdosfs/msdosfs_denode.c

ufs, msdosfs: do not record witness order when creating vnodeClosedPublicActions