atrtc.c: handle _STA object indcate it is not functional.
Needs ReviewPublic
Actions

Authored by takawata on Jan 14 2022, 6:36 AM.

Details

Reviewers

wulf
imp
jhb

Summary

Enable cmos register access from ACPI only and relux register access restriction when RTC _STA object indicate not functional. This is needed for upcoming ACPI000E device (I name it acpi_rtc.) for some implementation.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 43923
Build 40811: arc lint + arc unit

Event Timeline

takawata requested review of this revision.Jan 14 2022, 6:36 AM

takawata created this revision.

Harbormaster completed remote builds in B43923: Diff 101451.Jan 14 2022, 6:36 AM

takawata added child revisions: D33892: atrtc: Install address space handler for \_SB and its descendant., D33891: acpi.c: ignore _STA for atrtc SystemCMOS address space is exist if CMOS RTC Not Present bit is not set at IAPC_BOOT_ARCH in FADT., D33897: Add ACPI Alarm and Day Time Driver..Jan 14 2022, 6:52 AM

takawata removed a child revision: D33891: acpi.c: ignore _STA for atrtc SystemCMOS address space is exist if CMOS RTC Not Present bit is not set at IAPC_BOOT_ARCH in FADT..Jan 14 2022, 6:54 AM

takawata added a parent revision: D33891: acpi.c: ignore _STA for atrtc SystemCMOS address space is exist if CMOS RTC Not Present bit is not set at IAPC_BOOT_ARCH in FADT..

takawata removed a child revision: D33892: atrtc: Install address space handler for \_SB and its descendant..Jan 14 2022, 6:56 AM

takawata added a parent revision: D33892: atrtc: Install address space handler for \_SB and its descendant..

wulf added inline comments.Apr 25 2023, 4:14 PM

sys/x86/isa/atrtc.c
508	blank line is missed
510	- if (acpi_rtc_is_present){ + if (acpi_rtc_is_present) {
514	- }else{ + } else {
534	blank line is missed
535	- if(sc->is_active) + if (sc->is_active)

wulf added inline comments.Apr 25 2023, 4:16 PM

sys/x86/isa/atrtc.c
298	I do not understand what !acpi_rtc_is_present check does here. This code opens a lot of RTC registers for write if execution of _STA method returned 'Not present'. To make region handler dummy, if it is required, !acpi_rtc_is_present check should be moved to atrtc_acpi_cmos_handler() and should return AE_OK on success. P.S. soft context is available in atrtc_acpi_cmos_handler(), so acpi_rtc_is_present global variable may be converted to sc->is_present

Revision Contents
Changeset List

Path

Size

sys/

x86/

isa/

atrtc.c

24 lines

Diff 101451

View Options

atrtc.c: handle _STA object indcate it is not functional.Needs ReviewPublicActions