Page MenuHomeFreeBSD

games/neo: New port
ClosedPublic

Authored by driesm on Dec 16 2021, 11:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 2:28 AM
Unknown Object (File)
Wed, Nov 27, 2:35 PM
Unknown Object (File)
Nov 22 2024, 3:53 AM
Unknown Object (File)
Nov 16 2024, 11:33 AM
Unknown Object (File)
Nov 16 2024, 4:50 AM
Unknown Object (File)
Oct 7 2024, 11:04 PM
Unknown Object (File)
Oct 2 2024, 11:52 PM
Unknown Object (File)
Sep 28 2024, 2:51 PM
Subscribers

Details

Summary
games/neo: New port

cmatrix clone with 32-bit color and Unicode support.

 Approved by:		tbd (mentor)
 Differential Revision:	https://reviews.freebsd.org/D33507
Test Plan

Testport looks good and linters are happy.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 43465
Build 40353: arc lint + arc unit

Event Timeline

driesm added reviewers: philip, 0mp.
driesm edited the test plan for this revision. (Show Details)
0mp requested changes to this revision.Dec 16 2021, 3:38 PM
0mp added inline comments.
misc/neo/Makefile
4 ↗(On Diff #100143)

games is a better one for these kind of "fun" programs.

27 ↗(On Diff #100143)

We should try to install manual page at share/man/man6 instead of man/man6. This is fairly recent change. See the CHANGES file.cd

misc/neo/pkg-plist
1 ↗(On Diff #100143)

This is probably too short for a pkg-plist file. Use PLIST_FILES instead please :)

This revision now requires changes to proceed.Dec 16 2021, 3:38 PM
misc/neo/Makefile
4 ↗(On Diff #100143)

To be consistent, I followed category of cmatrix, where it is a clone of but enhanced :)

27 ↗(On Diff #100143)

Will do!

misc/neo/pkg-plist
1 ↗(On Diff #100143)

I generally like a pkg-plist even for a small port or files to install. Is there like a hard value of when to not use it?
Or is it a good practice, to eg use PLIST_FILES for under 4 files for example?

Install man page under share/man

misc/neo/Makefile
4 ↗(On Diff #100143)

Mmm, I see. I'd put it into games anyway. cmatrix should be moved there as well at some point. This is just my personal recommendation. :D

misc/neo/pkg-plist
1 ↗(On Diff #100143)

It is a good practice to do it for 4 items. Sometimes, even more. The PLIST_FILES example in PHB has more files than 4.

The reason is that it is nice not to create additional files when unnecessary.

Use PLIST_FILES, PORTDOCS and move to games.

driesm retitled this revision from misc/neo: New port to gams/neo: New port.Dec 19 2021, 11:26 AM
driesm edited the summary of this revision. (Show Details)
driesm retitled this revision from gams/neo: New port to games/neo: New port.Dec 19 2021, 7:15 PM
This revision is now accepted and ready to land.Dec 20 2021, 10:43 AM
This revision was automatically updated to reflect the committed changes.