games/neo: New port
ClosedPublic
Actions

Authored by driesm on Dec 16 2021, 11:19 AM.

Details

Reviewers

philip
0mp

Commits

R11:1cc3eec7c35d: games/neo: New port

Summary

games/neo: New port

cmatrix clone with 32-bit color and Unicode support.

 Approved by:		tbd (mentor)
 Differential Revision:	https://reviews.freebsd.org/D33507

Test Plan

Testport looks good and linters are happy.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 43422
Build 40310: arc lint + arc unit

Event Timeline

driesm created this revision.Dec 16 2021, 11:19 AM

Herald added a subscriber: mat. · View Herald TranscriptDec 16 2021, 11:19 AM

driesm requested review of this revision.Dec 16 2021, 11:19 AM

Harbormaster completed remote builds in B43414: Diff 100143.Dec 16 2021, 11:19 AM

driesm edited the summary of this revision. (Show Details)Dec 16 2021, 11:20 AM

driesm added reviewers: philip, 0mp.

driesm edited the test plan for this revision. (Show Details)

0mp requested changes to this revision.Dec 16 2021, 3:38 PM

0mp added inline comments.

misc/neo/Makefile
5	games is a better one for these kind of "fun" programs.
28	We should try to install manual page at share/man/man6 instead of man/man6. This is fairly recent change. See the CHANGES file.cd
misc/neo/pkg-plist
2	This is probably too short for a pkg-plist file. Use PLIST_FILES instead please :)

This revision now requires changes to proceed.Dec 16 2021, 3:38 PM

driesm added inline comments.Dec 16 2021, 3:51 PM

misc/neo/Makefile
5	To be consistent, I followed category of cmatrix, where it is a clone of but enhanced :)
28	Will do!
misc/neo/pkg-plist
2	I generally like a pkg-plist even for a small port or files to install. Is there like a hard value of when to not use it? Or is it a good practice, to eg use PLIST_FILES for under 4 files for example?

Install man page under share/man

Harbormaster completed remote builds in B43422: Diff 100155.Dec 16 2021, 5:00 PM

driesm marked an inline comment as done.Dec 16 2021, 5:00 PM

0mp added inline comments.Dec 18 2021, 4:14 PM

misc/neo/Makefile
5	Mmm, I see. I'd put it into games anyway. cmatrix should be moved there as well at some point. This is just my personal recommendation. :D
misc/neo/pkg-plist
2	It is a good practice to do it for 4 items. Sometimes, even more. The PLIST_FILES example in PHB has more files than 4. The reason is that it is nice not to create additional files when unnecessary.