Page MenuHomeFreeBSD

dtrace: Disable getf() as it is broken on FreeBSD.
ClosedPublic

Authored by domagoj.stolfa_gmail.com on Dec 10 2021, 7:26 PM.
Tags
None
Referenced Files
F167927383: D33378.id100220.diff
Tue, Aug 25, 11:32 AM
F167915028: D33378.id.diff
Tue, Aug 25, 10:08 AM
F167845827: D33378.diff
Mon, Aug 24, 11:24 PM
Unknown Object (File)
Mon, Aug 24, 9:11 AM
Unknown Object (File)
Sun, Aug 23, 7:29 AM
Unknown Object (File)
Sun, Aug 23, 7:18 AM
Unknown Object (File)
Sat, Aug 22, 11:44 PM
Unknown Object (File)
Fri, Aug 21, 11:04 AM
Subscribers

Details

Summary

getf() on FreeBSD calls _sx_slock(), _sx_sunlock() and fget_locked().
Furthermore, it does not set the per-core fault flag, meaning it
usually ends up in a double fault panic once getf() does get called,
especially from fbt.

Reviewing the DTrace Toolkit + a number of other scripts scattered
around FreeBSD, I have not been able to find one use of getf(). Given
how broken the implementation currently is, we disable it until it
can be implemented properly.

Also comment out a test in aggs/tst.subr.d for getf().

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable