games/neo: New port cmatrix clone with 32-bit color and Unicode support. Approved by: tbd (mentor) Differential Revision: https://reviews.freebsd.org/D33507
Details
- Reviewers
philip 0mp - Commits
- R11:1cc3eec7c35d: games/neo: New port
Testport looks good and linters are happy.
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 43414 Build 40302: arc lint + arc unit
Event Timeline
misc/neo/Makefile | ||
---|---|---|
4 | games is a better one for these kind of "fun" programs. | |
27 | We should try to install manual page at share/man/man6 instead of man/man6. This is fairly recent change. See the CHANGES file.cd | |
misc/neo/pkg-plist | ||
1 | This is probably too short for a pkg-plist file. Use PLIST_FILES instead please :) |
misc/neo/Makefile | ||
---|---|---|
4 | To be consistent, I followed category of cmatrix, where it is a clone of but enhanced :) | |
27 | Will do! | |
misc/neo/pkg-plist | ||
1 | I generally like a pkg-plist even for a small port or files to install. Is there like a hard value of when to not use it? |
misc/neo/Makefile | ||
---|---|---|
4 | Mmm, I see. I'd put it into games anyway. cmatrix should be moved there as well at some point. This is just my personal recommendation. :D | |
misc/neo/pkg-plist | ||
1 | It is a good practice to do it for 4 items. Sometimes, even more. The PLIST_FILES example in PHB has more files than 4. The reason is that it is nice not to create additional files when unnecessary. |