Page MenuHomeFreeBSD

Fix a memory leak in dhclient
ClosedPublic

Authored by trix_juniper.net on Mar 13 2017, 4:56 PM.

Details

Summary

clparse.c parse_client_lease_statement
When there is an error parsing, call free_client_lease to free the memory assigned to the variable 'lease' before returning early.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

ngie accepted this revision.Mar 13 2017, 4:58 PM
This revision is now accepted and ready to land.Mar 13 2017, 4:58 PM
This revision was automatically updated to reflect the committed changes.
ngie added a comment.Mar 13 2017, 5:06 PM

Thank you for the submission! I'll take care of the other memory leaks noted by Coverity.