Page MenuHomeFreeBSD
Differential D9992

Fix a memory leak in dhclient
ClosedPublic
Actions

Authored by trix_juniper.net on Mar 13 2017, 4:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 2, 10:17 PM
Unknown Object (File)
Sat, Jan 31, 10:26 AM
Unknown Object (File)
Jan 17 2026, 1:53 PM
Unknown Object (File)
Jan 16 2026, 10:28 AM
Unknown Object (File)
Dec 30 2025, 3:17 PM
Unknown Object (File)
Dec 25 2025, 10:01 PM
Unknown Object (File)
Dec 21 2025, 1:17 PM
Unknown Object (File)
Dec 8 2025, 5:39 PM
View All 81 Files
Subscribers
imp

Details

Reviewers
brooks
ngie
Commits
rS315199: sbin/dhclient: fix a memory leak in parse_client_lease_statement(..)
Summary

clparse.c parse_client_lease_statement
When there is an error parsing, call free_client_lease to free the memory assigned to the variable 'lease' before returning early.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trix_juniper.net created this revision.Mar 13 2017, 4:56 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 13 2017, 4:56 PM
ngie accepted this revision.Mar 13 2017, 4:58 PM
This revision is now accepted and ready to land.Mar 13 2017, 4:58 PM
Closed by commit rS315199: sbin/dhclient: fix a memory leak in parse_client_lease_statement(..) (authored by ngie). · Explain WhyMar 13 2017, 5:06 PM
This revision was automatically updated to reflect the committed changes.
ngie mentioned this in rS315199: sbin/dhclient: fix a memory leak in parse_client_lease_statement(..).
ngie added a comment.Mar 13 2017, 5:06 PM

Thank you for the submission! I'll take care of the other memory leaks noted by Coverity.

Revision Contents
Changeset List

PathSize
head/
sbin/
dhclient/
1 line

Diff 26224

View Options

head/sbin/dhclient/clparse.c

Loading...