Fix a memory leak in dhclient
ClosedPublic
Actions

Authored by trix_juniper.net on Mar 13 2017, 4:56 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 23, 6:30 PM

	Unknown Object (File)
	Mon, Apr 20, 12:47 AM

	Unknown Object (File)
	Sun, Apr 19, 3:13 AM

	Unknown Object (File)
	Wed, Apr 15, 7:44 AM

	Unknown Object (File)
	Tue, Apr 14, 6:19 PM

	Unknown Object (File)
	Tue, Apr 14, 6:11 PM

	Unknown Object (File)
	Fri, Apr 10, 12:36 AM

	Unknown Object (File)
	Tue, Apr 7, 3:01 PM

View All 96 Files

Subscribers

imp

Details

Reviewers

brooks
ngie

Commits

rS315199: sbin/dhclient: fix a memory leak in parse_client_lease_statement(..)

Summary

clparse.c parse_client_lease_statement
When there is an error parsing, call free_client_lease to free the memory assigned to the variable 'lease' before returning early.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trix_juniper.net created this revision.Mar 13 2017, 4:56 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 13 2017, 4:56 PM

ngie accepted this revision.Mar 13 2017, 4:58 PM

This revision is now accepted and ready to land.Mar 13 2017, 4:58 PM

Closed by commit rS315199: sbin/dhclient: fix a memory leak in parse_client_lease_statement(..) (authored by ngie). · Explain WhyMar 13 2017, 5:06 PM

This revision was automatically updated to reflect the committed changes.

ngie mentioned this in rS315199: sbin/dhclient: fix a memory leak in parse_client_lease_statement(..).

Thank you for the submission! I'll take care of the other memory leaks noted by Coverity.

Revision Contents
Changeset List

Path

Size

head/

sbin/

dhclient/

clparse.c

1 line

Diff 26224

View Options

head/sbin/dhclient/clparse.c

Fix a memory leak in dhclientClosedPublicActions