Page MenuHomeFreeBSD

Fix a memory leak in libutil
ClosedPublic

Authored by trix_juniper.net on Mar 2 2017, 3:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 27, 4:51 PM
Unknown Object (File)
Fri, Sep 26, 5:56 PM
Unknown Object (File)
Thu, Sep 18, 12:42 PM
Unknown Object (File)
Sat, Sep 13, 6:23 AM
Unknown Object (File)
Sep 9 2025, 9:33 AM
Unknown Object (File)
Sep 4 2025, 4:52 PM
Unknown Object (File)
Aug 14 2025, 1:01 PM
Unknown Object (File)
Aug 13 2025, 1:46 PM
Subscribers

Details

Summary

kinfo_getvmobject.c kinfo_getvmobject
When sysctlbyname fails, free buf before returning.

Test Plan

Use clang's static analyzer, scan-build, to find the problem and show resolution.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trix_juniper.net retitled this revision from to Fix a memory leak in libutil.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net added reviewers: stevek, jhb.
trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.
jhb edited edge metadata.

Hmm, I was going to suggest looking in other places in libutil that I copied this from, but it seems other kinfo_getfoo() functions don't use a loop to retry but just add a fudge factor to the size and hope it is enough.

This revision is now accepted and ready to land.Mar 2 2017, 5:13 PM
This revision was automatically updated to reflect the committed changes.