Page MenuHomeFreeBSD
Differential D9831

xen/netfront: fix inbound packet flags for checksum offload
ClosedPublic
Actions

Authored by royger on Feb 28 2017, 8:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:31 PM
Unknown Object (File)
Oct 16 2024, 1:03 PM
Unknown Object (File)
Oct 16 2024, 1:03 PM
Unknown Object (File)
Oct 16 2024, 1:03 PM
Unknown Object (File)
Oct 16 2024, 12:39 PM
Unknown Object (File)
Oct 5 2024, 12:54 PM
Unknown Object (File)
Oct 2 2024, 9:30 PM
Unknown Object (File)
Oct 1 2024, 9:22 PM
View All 47 Files
Subscribers
imp

Details

Reviewers
liuw_liuw.name
Group Reviewers
network
Commits
rS314842: xen/netfront: fix inbound packet flags for checksum offload
Summary

Currently netfront is setting the flags of inbound packets with the checksum not present (offloaded) to (CSUM_IP_CHECKED | CSUM_IP_VALID | CSUM_DATA_VALID | CSUM_PSEUDO_HDR). According to the mbuf(9) man page this is not the correct combination of flags, it should instead be (CSUM_DATA_VALID | CSUM_PSEUDO_HDR).

Sponsored by: Citrix Systems R&D

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 7787

Event Timeline

royger updated this revision to Diff 25778.Feb 28 2017, 8:41 AM
royger retitled this revision from to xen/netfront: fix inbound packet flags for checksum offload.
royger updated this object.
royger edited the test plan for this revision. (Show Details)
royger added reviewers: liuw_liuw.name, network.
royger set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2017, 8:41 AM
liuw_liuw.name accepted this revision.Mar 1 2017, 10:39 AM
liuw_liuw.name edited edge metadata.

Looks good to me. Thanks for fixing this!

This revision is now accepted and ready to land.Mar 1 2017, 10:39 AM
Closed by commit rS314842: xen/netfront: fix inbound packet flags for checksum offload (authored by royger). · Explain WhyMar 7 2017, 9:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
xen/
netfront/
16 lines

Diff 25778

View Options

sys/dev/xen/netfront/netfront.c

Loading...