Page MenuHomeFreeBSD
Differential D9831

xen/netfront: fix inbound packet flags for checksum offload
ClosedPublic
Actions

Authored by royger on Feb 28 2017, 8:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2023, 9:04 PM
Unknown Object (File)
Oct 29 2023, 9:12 PM
Unknown Object (File)
Jun 3 2023, 1:22 AM
Unknown Object (File)
Feb 23 2023, 4:09 PM
Unknown Object (File)
Jan 7 2023, 6:25 PM
Unknown Object (File)
Dec 31 2022, 1:51 AM
Unknown Object (File)
Dec 15 2022, 3:54 AM
Unknown Object (File)
Apr 23 2017, 2:57 PM
View All 16 Files
Subscribers
imp

Details

Reviewers
liuw_liuw.name
Group Reviewers
network
Commits
rS314842: xen/netfront: fix inbound packet flags for checksum offload
Summary

Currently netfront is setting the flags of inbound packets with the checksum not present (offloaded) to (CSUM_IP_CHECKED | CSUM_IP_VALID | CSUM_DATA_VALID | CSUM_PSEUDO_HDR). According to the mbuf(9) man page this is not the correct combination of flags, it should instead be (CSUM_DATA_VALID | CSUM_PSEUDO_HDR).

Sponsored by: Citrix Systems R&D

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

royger updated this revision to Diff 25778.Feb 28 2017, 8:41 AM
royger retitled this revision from to xen/netfront: fix inbound packet flags for checksum offload.
royger updated this object.
royger edited the test plan for this revision. (Show Details)
royger added reviewers: liuw_liuw.name, network.
royger set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2017, 8:41 AM
liuw_liuw.name accepted this revision.Mar 1 2017, 10:39 AM
liuw_liuw.name edited edge metadata.

Looks good to me. Thanks for fixing this!

This revision is now accepted and ready to land.Mar 1 2017, 10:39 AM
Closed by commit rS314842: xen/netfront: fix inbound packet flags for checksum offload (authored by royger). · Explain WhyMar 7 2017, 9:19 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
xen/
netfront/
16 lines

Diff 26060

View Options

head/sys/dev/xen/netfront/netfront.c

Loading...