Differential D9831

xen/netfront: fix inbound packet flags for checksum offload
ClosedPublic
Actions

Authored by royger on Feb 28 2017, 8:41 AM.

Tags

None

Referenced Files

	F167330927: D9831.id25778.diff
	Thu, Aug 20, 11:25 PM

	F167311199: D9831.id25778.diff
	Thu, Aug 20, 8:25 PM

	Unknown Object (File)
	Tue, Aug 18, 9:35 PM

	Unknown Object (File)
	Tue, Aug 18, 8:58 PM

	Unknown Object (File)
	Tue, Aug 18, 8:10 PM

	Unknown Object (File)
	Tue, Aug 18, 2:20 PM

	Unknown Object (File)
	Tue, Aug 18, 12:14 PM

	Unknown Object (File)
	Sat, Aug 8, 7:22 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS314842: xen/netfront: fix inbound packet flags for checksum offload

Summary

Currently netfront is setting the flags of inbound packets with the checksum not present (offloaded) to (CSUM_IP_CHECKED | CSUM_IP_VALID | CSUM_DATA_VALID | CSUM_PSEUDO_HDR). According to the mbuf(9) man page this is not the correct combination of flags, it should instead be (CSUM_DATA_VALID | CSUM_PSEUDO_HDR).

Sponsored by: Citrix Systems R&D

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

royger updated this revision to Diff 25778.Feb 28 2017, 8:41 AM

royger retitled this revision from to xen/netfront: fix inbound packet flags for checksum offload.

royger updated this object.

royger edited the test plan for this revision. (Show Details)

royger added reviewers: liuw_liuw.name, network.

royger set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 28 2017, 8:41 AM

Looks good to me. Thanks for fixing this!

This revision is now accepted and ready to land.Mar 1 2017, 10:39 AM

Closed by commit rS314842: xen/netfront: fix inbound packet flags for checksum offload (authored by royger). · Explain WhyMar 7 2017, 9:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

xen/

netfront/

16 lines

Diff 26060

head/sys/dev/xen/netfront/netfront.c

Loading...