Page MenuHomeFreeBSD

math/openblas: fix build on 12-CURRENT armv6
ClosedPublic

Authored by jrm on Feb 25 2017, 4:29 PM.

Details

Summary

math/openblas: fix build on 12-CURRENT armv6

Note, the build still fails on 11.0-RELEASE armv6:
http://pkg.awarnach.mathstat.dal.ca/data/11armv6-default/2017-02-25_09h14m08s/logs/errors/openblas-0.2.19,1.log

While here also

  • Fix portlint warnings
  • Add LICENSE_FILE
Test Plan

portlint -C: OK
testport: OK (poudriere: 10.3-RELEASE-p10, i386, default options)
testport: OK (poudriere: 10.3-RELEASE-p10, amd64, default options)
testport: OK (poudriere: 11.0-RELEASE-p1, i386, default options)
testport: OK (poudriere: 11.0-RELEASE-p1, amd64, default options)
testport: OK (poudriere: 11.0-RELEASE-p1, arm.armv6, default options)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jrm retitled this revision from to math/openblas: fix build on 12-CURRENT armv6.
jrm updated this object.
jrm edited the test plan for this revision. (Show Details)
jrm added reviewers: swills, AMDmi3.
jrm added a subscriber: mikael.

Ok, then it sounds like this diff is worth committing. I will commit only your changes and wait for the maintainer's feedback before committing the other changes.

In the patch that you submitted was this line change intentional? If I'm not mistaken there is no change in logic.

-.if ! ( ${PORT_OPTIONS:MDYNAMIC_ARCH} && ( ${ARCH} == "amd64" || ${ARCH} == "i386" ) )
+.if ( ! ${PORT_OPTIONS:MDYNAMIC_ARCH} && ( ${ARCH} == "amd64" || ${ARCH} == "i386" ) )

Do not include changes to options. That will be done in a separate diff.

This revision was automatically updated to reflect the committed changes.