Page MenuHomeFreeBSD

Fix memory issues with nvi
Needs ReviewPublic

Authored by trix_juniper.net on Feb 23 2017, 11:28 PM.

Details

Reviewers
bapt
stevek
Summary

ex_cscope.c cscope_find fix a double free of the variable np by poisoning it after it is freed.

exf.c file_backup fix a memory leak by freeing the variable d.

Test Plan

Run clang's static analyzer, scan-build, before to reproduce the problems. Run scan-build after to verify resolution.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint Skipped
Unit
Unit Tests Skipped

Event Timeline

trix_juniper.net retitled this revision from to Fix memory issues with nvi.
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net added reviewers: stevek, bapt.
trix_juniper.net set the repository for this revision to rS FreeBSD src repository.
bapt added inline comments.Feb 25 2017, 6:49 PM
contrib/nvi/common/exf.c
1191

The test is not needed, free already do that test

bapt edited edge metadata.Feb 25 2017, 6:50 PM

Have you tried to upstream that fix? upstream is here: https://github.com/lichray/nvi2

Sure, let me give it a try.