Fix memory issues with nvi
Needs ReviewPublic
Actions

Authored by trix_juniper.net on Feb 23 2017, 11:28 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Dec 12 2024, 6:52 PM

	Unknown Object (File)
	Oct 22 2024, 5:55 AM

	Unknown Object (File)
	Oct 8 2024, 4:57 PM

	Unknown Object (File)
	Sep 29 2024, 1:34 AM

	Unknown Object (File)
	Sep 22 2024, 10:51 PM

	Unknown Object (File)
	Sep 21 2024, 6:26 AM

	Unknown Object (File)
	Sep 21 2024, 6:25 AM

	Unknown Object (File)
	Sep 16 2024, 11:32 PM

View All 35 Files

Subscribers

imp

Details

Reviewers

bapt
stevek

Summary

ex_cscope.c cscope_find fix a double free of the variable np by poisoning it after it is freed.

exf.c file_backup fix a memory leak by freeing the variable d.

Test Plan

Run clang's static analyzer, scan-build, before to reproduce the problems. Run scan-build after to verify resolution.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

trix_juniper.net updated this revision to Diff 25641.Feb 23 2017, 11:28 PM

trix_juniper.net retitled this revision from to Fix memory issues with nvi.

trix_juniper.net updated this object.

trix_juniper.net edited the test plan for this revision. (Show Details)

trix_juniper.net added reviewers: stevek, bapt.

trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2017, 11:28 PM

bapt added inline comments.Feb 25 2017, 6:49 PM

contrib/nvi/common/exf.c
1191	The test is not needed, free already do that test

Have you tried to upstream that fix? upstream is here: https://github.com/lichray/nvi2

Sure, let me give it a try.

Revision Contents
Changeset List

Path

Size

contrib/

nvi/

common/

exf.c

2 lines

ex/

ex_cscope.c

4 lines

Diff 25641

View Options

contrib/nvi/common/exf.c