Improve SSL patch for qt4-network
ClosedPublic
Actions

Authored by rezny on Feb 22 2017, 6:24 PM.

Details

Reviewers

swills
feld

Group Reviewers

kde

Commits

rP434635: Replace USE_OPENSSL with USES=ssl and bump portrevision for SSL changes.
rP434634: Adjust SSL patches to match behavior of Qt5 in regards to SSL/TLS versions.

Summary

Fix up the SSL patch in qt4-network for functional parity with qt5-network to the extent possible. Logic for SSL/TLS version now matches qt5 instead of restricting to TLSv1.0 only, runtime loading of SSL library is same as qt5, and USES=ssl in place of USE_OPENSSL. Further details also in PR 216781.

Test Plan

run tested on 11 amd64 with LibreSSL 2.5.1, Poudriere 10.3/11.0 amd64/i386 with OpenSSL OK

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rezny updated this revision to Diff 25545.Feb 22 2017, 6:24 PM

rezny retitled this revision from to Improve SSL patch for qt4-network.

rezny updated this object.

rezny edited the test plan for this revision. (Show Details)

rezny added reviewers: kde, swills, feld.

Herald added a subscriber: mat. · View Herald TranscriptFeb 22 2017, 6:24 PM

Approved

This revision is now accepted and ready to land.Feb 22 2017, 6:29 PM

Could you please always add some little description to the patches? So that in the future, when updating Qt we don't have to think too hard about these?

Closed by commit rP434634: Adjust SSL patches to match behavior of Qt5 in regards to SSL/TLS versions. (authored by rezny). · Explain WhyFeb 22 2017, 7:38 PM

This revision was automatically updated to reflect the committed changes.