Fix a memory leak in bridge_interfaces.
ClosedPublic
Actions

Authored by trix_juniper.net on Feb 19 2017, 5:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Feb 22, 3:55 AM

	Unknown Object (File)
	Thu, Feb 20, 1:30 AM

	Unknown Object (File)
	Tue, Feb 18, 6:29 PM

	Unknown Object (File)
	Wed, Feb 5, 4:10 PM

	Unknown Object (File)
	Jan 7 2025, 8:09 PM

	Unknown Object (File)
	Oct 26 2024, 6:33 AM

	Unknown Object (File)
	Oct 3 2024, 1:32 AM

	Unknown Object (File)
	Oct 2 2024, 3:07 PM

View All 71 Files

Subscribers

imp

Details

Reviewers

stevek
adrian

Commits

rS313979: [ifconfig] fix a memory leak!

Summary

The local pointer 'pad' is assigned memory that is freed before bridge_interfaces returns.

Test Plan

Run clang's static analyzer scan-build before to find the problem, run it after to show problem is resolved.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trix_juniper.net updated this revision to Diff 25383.Feb 19 2017, 5:30 PM

trix_juniper.net retitled this revision from to Fix a memory leak in bridge_interfaces..

trix_juniper.net updated this object.

trix_juniper.net edited the test plan for this revision. (Show Details)

trix_juniper.net added reviewers: stevek, adrian.

trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2017, 5:30 PM

adrian accepted this revision.Feb 19 2017, 6:24 PM

adrian edited edge metadata.

This revision is now accepted and ready to land.Feb 19 2017, 6:24 PM

Closed by commit rS313979: [ifconfig] fix a memory leak! (authored by adrian). · Explain WhyFeb 20 2017, 3:13 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

ifconfig/

ifbridge.c

2 lines

Diff 25407

View Options

head/sbin/ifconfig/ifbridge.c

Fix a memory leak in bridge_interfaces.ClosedPublicActions