Page MenuHomeFreeBSD
Differential D9675

Fix a memory leak in bridge_interfaces.
ClosedPublic
Actions

Authored by trix_juniper.net on Feb 19 2017, 5:30 PM.
Tags
None
Referenced Files
F166222101: D9675.id25383.diff
Wed, Aug 12, 11:23 AM
F166222051: D9675.id25407.diff
Wed, Aug 12, 11:23 AM
F166212308: D9675.diff
Wed, Aug 12, 9:49 AM
Unknown Object (File)
Tue, Aug 4, 3:28 AM
Unknown Object (File)
Tue, Aug 4, 2:31 AM
Unknown Object (File)
Mon, Aug 3, 1:12 AM
Unknown Object (File)
Tue, Jul 28, 11:53 AM
Unknown Object (File)
Mon, Jul 27, 4:16 AM
View All Files
Subscribers
imp

Details

Reviewers
stevek
adrian
Commits
rS313979: [ifconfig] fix a memory leak!
Summary

The local pointer 'pad' is assigned memory that is freed before bridge_interfaces returns.

Test Plan

Run clang's static analyzer scan-build before to find the problem, run it after to show problem is resolved.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trix_juniper.net updated this revision to Diff 25383.Feb 19 2017, 5:30 PM
trix_juniper.net retitled this revision from to Fix a memory leak in bridge_interfaces..
trix_juniper.net updated this object.
trix_juniper.net edited the test plan for this revision. (Show Details)
trix_juniper.net added reviewers: stevek, adrian.
trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptFeb 19 2017, 5:30 PM
adrian accepted this revision.Feb 19 2017, 6:24 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2017, 6:24 PM
Closed by commit rS313979: [ifconfig] fix a memory leak! (authored by adrian). · Explain WhyFeb 20 2017, 3:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sbin/
ifconfig/
2 lines

Diff 25407

View Options

head/sbin/ifconfig/ifbridge.c

Loading...