more options helpers

[makc]

Summary

Add CMAKE_ENV and QMAKE_ENV to the list of available helpers

[antoine]

Since in Uses/[cq]make.mk, there is:
[CQ]MAKE_ENV?= ${CONFIGURE_ENV}
the option helpers will totally override [CQ]MAKE_ENV (content of CONFIGURE_ENV will not be used)

Is this behaviour intended?

If not, there is already an option helper for CONFIGURE_ENV

[makc]

I always thought it's by design, but I don't know if this is really needed for any port. Anyway [CQ]MAKE_ENV are already in use, so helpers for them would be nice to have.

[mat]

I'm with @antoine on this, both cmake and qmake replace configure, and both *_ENV already inherit from CONFIGURE_ENV.

[makc]

In D966#6, @mat wrote:

I'm with @antoine on this, both cmake and qmake replace configure, and both *_ENV already inherit from CONFIGURE_ENV.

Until you use [CQ]MAKE_ENV, which reset CONFIGURE_ENV and any CONFIGURE_ENV modifications becomes no-op. But even if it were not the case, for the sake of consistency I'd like to have helpers for [CQ]MAKE_ENV similar to *_ARGS.

In principle we could consider reworking cmake.mk/qmake.mk for tightening with CONFIGURE stuff in bsd.port.mk, but this is a different task and I don't see much benefit from it now. Any change for any configure tool will require testing for all of them. There are also weird ports (not many but still) that use both gnu configure and qmake, so they would need special treatment anyway.

[makc]

Any comment? Should I consider the discussion closed?

[bapt]

CONFIGURE_ENV has to be seen has configure phase env not configure script env, and imho everything that needs ENV in configure phase should just use CONFIGURE_ENV instead of RANDOM_ENV imho it would be better to work on clarifying this than adding those new helpers.

[makc]

In D966#10, @bapt wrote:

CONFIGURE_ENV has to be seen has configure phase env not configure script env, and imho everything that needs ENV in configure phase should just use CONFIGURE_ENV instead of RANDOM_ENV imho it would be better to work on clarifying this than adding those new helpers.

I see, I'll work on converting [QC]MAKE_ENV to CONFIGURE_ENV.