Fix a memory leak in set80211chanlist
ClosedPublic
Actions

Authored by trix_juniper.net on Feb 17 2017, 6:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Aug 26, 10:22 AM

	Unknown Object (File)
	Tue, Aug 25, 1:55 AM

	Unknown Object (File)
	Sat, Aug 22, 6:38 AM

	Unknown Object (File)
	Fri, Aug 21, 11:28 AM

	Unknown Object (File)
	Wed, Aug 19, 8:26 AM

	Unknown Object (File)
	Sat, Aug 15, 5:48 AM

	Unknown Object (File)
	Mon, Aug 10, 7:34 PM

	Unknown Object (File)
	Mon, Aug 10, 7:34 PM

View All Files

Subscribers

imp

Details

Reviewers

stevek
adrian

Commits

rS313978: [ifconfig] fix a memory leak.

Summary

The variable temp is allocated but never freed, now free it when it is not used.

Test Plan

Run clang's static analyzer scan-build before to find the problem, then run after to verify the fix.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trix_juniper.net updated this revision to Diff 25324.Feb 17 2017, 6:39 PM

trix_juniper.net retitled this revision from to Fix a memory leak in set80211chanlist.

trix_juniper.net updated this object.

trix_juniper.net edited the test plan for this revision. (Show Details)

trix_juniper.net added reviewers: stevek, adrian.

trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2017, 6:39 PM

oops!

This revision is now accepted and ready to land.Feb 17 2017, 6:42 PM

Closed by commit rS313978: [ifconfig] fix a memory leak. (authored by adrian). · Explain WhyFeb 20 2017, 3:11 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

ifconfig/

ifieee80211.c

1 line

Diff 25406

View Options

head/sbin/ifconfig/ifieee80211.c

Fix a memory leak in set80211chanlistClosedPublicActions