Page MenuHomeFreeBSD

Add myself as a new ports committer
ClosedPublic

Authored by tobik on Feb 14 2017, 2:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 29, 6:20 AM
Unknown Object (File)
Sep 17 2024, 4:04 AM
Unknown Object (File)
Sep 1 2024, 11:51 AM
Unknown Object (File)
Jun 6 2024, 4:28 PM
Unknown Object (File)
May 11 2024, 12:24 AM
Unknown Object (File)
May 4 2024, 5:01 AM
Unknown Object (File)
May 3 2024, 5:27 PM
Unknown Object (File)
May 3 2024, 8:50 AM
Subscribers

Details

Summary

Add myself as a new ports committer

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tobik retitled this revision from to Add myself as a new ports committer.
tobik updated this object.
tobik edited the test plan for this revision. (Show Details)
tobik added reviewers: lme, mat.
mat edited edge metadata.

Looks good to me.

Side note, I changed your login here to @tobik, if you have not already done so, please remember to update your email address to use your @FreeBSD.org one.

This revision is now accepted and ready to land.Feb 14 2017, 2:34 PM
mat requested changes to this revision.Feb 14 2017, 2:35 PM
mat edited edge metadata.

For the first commits, please provide the commit message you plan on using in the review summary, something like:

Add myself as a new ports committer

Approved by: foo (mentor)
Differential Revision: https://...
This revision now requires changes to proceed.Feb 14 2017, 2:35 PM
In D9590#198138, @mat wrote:

For the first commits, please provide the commit message you plan on using in the review summary, something like:

Will do. I'm unable to change the summary here:

The value you have entered in "Summary" can not be parsed unambiguously when rendered in a commit message. Edit the message so that keywords like "Summary:" and "Test Plan:" do not appear at the beginning of lines. Parsed keys: revisionID.

But this is the commit message I'd use:

Add myself as a new ports committer

Approved by:	mat (mentor)
Differential Revision:	https://reviews.freebsd.org/D9590
mat edited edge metadata.
In D9590#198161, @tobik wrote:

The value you have entered in "Summary" can not be parsed unambiguously when rendered in a commit message. Edit the message so that keywords like "Summary:" and "Test Plan:" do not appear at the beginning of lines. Parsed keys: revisionID.

Mmmm, yes, phabricator is a bit silly sometime, instead of using a backticked code block, you may need to indent it (two spaces should be enought.

Anyway, the commit message look good, go ahead.

This revision is now accepted and ready to land.Feb 14 2017, 4:09 PM
This revision was automatically updated to reflect the committed changes.