Add myself as a new ports committer
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good to me.
Side note, I changed your login here to @tobik, if you have not already done so, please remember to update your email address to use your @FreeBSD.org one.
Comment Actions
For the first commits, please provide the commit message you plan on using in the review summary, something like:
Add myself as a new ports committer Approved by: foo (mentor) Differential Revision: https://...
Comment Actions
Will do. I'm unable to change the summary here:
The value you have entered in "Summary" can not be parsed unambiguously when rendered in a commit message. Edit the message so that keywords like "Summary:" and "Test Plan:" do not appear at the beginning of lines. Parsed keys: revisionID.
But this is the commit message I'd use:
Add myself as a new ports committer Approved by: mat (mentor) Differential Revision: https://reviews.freebsd.org/D9590
Comment Actions
Mmmm, yes, phabricator is a bit silly sometime, instead of using a backticked code block, you may need to indent it (two spaces should be enought.
Anyway, the commit message look good, go ahead.