Page MenuHomeFreeBSD
Differential D9557

Update cmake to 3.8.0
ClosedPublic
Actions

Authored by tcberner on Feb 12 2017, 5:44 PM.
Tags
None
Referenced Files
F106144411: D9557.diff
Thu, Dec 26, 3:20 AM
Unknown Object (File)
Sun, Dec 22, 6:19 AM
Unknown Object (File)
Sun, Dec 22, 6:18 AM
Unknown Object (File)
Sun, Dec 8, 7:40 AM
Unknown Object (File)
Sat, Dec 7, 10:35 AM
Unknown Object (File)
Thu, Dec 5, 5:23 PM
Unknown Object (File)
Nov 25 2024, 1:40 PM
Unknown Object (File)
Nov 23 2024, 5:38 AM
View All Files
Subscribers
mat

Details

Reviewers
rakuco
mat
Commits
rP438884: Update cmake and friends to 3.8.0
Summary
  • Update cmake to 3.8.0
  • Wait for the release :-)
Test Plan

Exp-Run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner updated this revision to Diff 25056.Feb 12 2017, 5:44 PM
tcberner retitled this revision from to Update cmake to 3.8.0.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added a reviewer: rakuco.
Herald added a subscriber: mat. · View Herald TranscriptFeb 12 2017, 5:44 PM
tcberner updated this revision to Diff 25057.Feb 12 2017, 5:45 PM
  • Fix plist in devel/cmake
rakuco edited edge metadata.Feb 12 2017, 6:10 PM

Do you intend to commit the RC to the ports tree? If so, you need to add a suffix that will be bumped/removed with newer RCs and the final release.

devel/cmake/Makefile
35 ↗(On Diff #25057)

Don't you need to do the same in cmake-gui?

tcberner added a comment.Feb 12 2017, 6:19 PM

Don't worry, I'll wait for the release.

tcberner updated this revision to Diff 25059.Feb 12 2017, 6:22 PM
tcberner marked an inline comment as done.
tcberner edited edge metadata.
  • Add security/rhash also to the LIB_DEPENDS of cmake-gui, as @rakuco correctly pointed out.
rakuco accepted this revision.Feb 12 2017, 7:16 PM
rakuco edited edge metadata.

lgtm then

This revision is now accepted and ready to land.Feb 12 2017, 7:16 PM
mat accepted this revision.Feb 13 2017, 4:17 PM
mat added a reviewer: mat.
mat added inline comments.
devel/cmake-doc/Makefile
4–5 ↗(On Diff #25059)

This should be:

DISTVERSION= 3.8.0-rc1

devel/cmake-gui/Makefile
4–5 ↗(On Diff #25059)

same.

devel/cmake/Makefile
4–5 ↗(On Diff #25059)

same.

tcberner added a comment.Feb 13 2017, 4:50 PM

Ah, DISTVERSION accepts -rc1, nice :)

I will update the diff once 3.8.0 is officially released -- so that does not really matter.

mat added a comment.Feb 13 2017, 5:15 PM
In D9557#197622, @tcberner wrote:

Ah, DISTVERSION accepts -rc1, nice :)

The whole point of DISTVERSION is to grok upstream version numbers into what pkg version understands.

So, yes, It'll turn -rc1 in .r1, for example.

tcberner updated this revision to Diff 27330.Apr 10 2017, 10:13 PM
tcberner edited edge metadata.

It finally got released...

I'll ask for an exp-run tomorrow.

This revision now requires review to proceed.Apr 10 2017, 10:13 PM
Harbormaster completed remote builds in B8672: Diff 27330.Apr 10 2017, 10:13 PM
tcberner updated this revision to Diff 27548.Apr 19 2017, 2:35 PM

Add patches to kmymoney-kde4:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218559

Harbormaster completed remote builds in B8795: Diff 27548.Apr 19 2017, 2:35 PM
rakuco accepted this revision.Apr 19 2017, 2:37 PM

lgtm

This revision is now accepted and ready to land.Apr 19 2017, 2:37 PM
Closed by commit rP438884: Update cmake and friends to 3.8.0 (authored by tcberner). · Explain WhyApr 19 2017, 3:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
devel/
cmake-doc/
2 lines
files/
12 lines
76 lines
cmake-gui/
5 lines
cmake-modules/
26 lines
cmake/
9 lines
6 lines
39 lines
finance/
kmymoney-kde4/
files/
12 lines
12 lines
irc/
irssi-fish/
2 lines
files/
16 lines

Diff 27550

View Options

head/devel/cmake-doc/Makefile

Loading...
View Options

head/devel/cmake-doc/files/patch-Utilities_Sphinx_apply__qthelp__css__workaround.cmake

Loading...
View Options

head/devel/cmake-doc/pkg-plist

Loading...
View Options

head/devel/cmake-gui/Makefile

Loading...
View Options

head/devel/cmake-modules/pkg-plist

Loading...
View Options

head/devel/cmake/Makefile

Loading...
View Options

head/devel/cmake/distinfo

Loading...
View Options

head/devel/cmake/pkg-plist

Loading...
View Options

head/finance/kmymoney-kde4/files/patch-kmymoney_plugins_onlinetasks_national_CMakeLists.txt

Loading...
View Options

head/finance/kmymoney-kde4/files/patch-kmymoney_plugins_onlinetasks_sepa_CMakeLists.txt

Loading...
View Options

head/irc/irssi-fish/Makefile

Loading...
View Options

head/irc/irssi-fish/files/patch-CMakeLists.txt

Loading...