Page MenuHomeFreeBSD
Differential D9408

Update misc/tellico-kde4 to 2.3.12
ClosedPublic
Actions

Authored by tcberner on Feb 1 2017, 4:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 15, 10:48 PM
Unknown Object (File)
Tue, Oct 15, 8:57 AM
Unknown Object (File)
Sun, Oct 13, 9:48 PM
Unknown Object (File)
Sat, Oct 12, 3:55 PM
Unknown Object (File)
Fri, Oct 11, 7:54 AM
Unknown Object (File)
Thu, Oct 10, 1:07 PM
Unknown Object (File)
Mon, Oct 7, 5:32 PM
Unknown Object (File)
Sat, Oct 5, 7:05 AM
View All 63 Files
Subscribers
None

Details

Reviewers
adridg
rakuco
mat
Group Reviewers
kde
Commits
rP433048: Update misc/tellico-kde4 to 2.3.12
Summary
  • Update
  • Add dependencies asked for by stage-qa

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner updated this revision to Diff 24629.Feb 1 2017, 4:41 PM
tcberner retitled this revision from to Update misc/tellico-kde4 to 2.3.12.
tcberner updated this object.
tcberner edited the test plan for this revision. (Show Details)
tcberner added reviewers: kde, rakuco, mat, adridg.
rakuco accepted this revision.Feb 1 2017, 4:42 PM
rakuco edited edge metadata.

lgtm

This revision is now accepted and ready to land.Feb 1 2017, 4:42 PM
Closed by commit rP433048: Update misc/tellico-kde4 to 2.3.12 (authored by tcberner). · Explain WhyFeb 1 2017, 4:51 PM
This revision was automatically updated to reflect the committed changes.
mat added inline comments.Feb 1 2017, 8:48 PM
head/misc/tellico-kde4/Makefile
14–20

Any reason for the re-ordering here ?

tcberner added a comment.Feb 1 2017, 8:56 PM

alphabetizing -- I thought that was the prefered order, no?

mat edited edge metadata.Feb 1 2017, 9:33 PM

Well I'm sure there is a sort police out there, everyone has their OCD.
But all in all, it does not matter at all, the order here is irrelevant.
The problem is that it makes it harder to read the diff to see what was added/removed :-)

tcberner added a comment.Feb 1 2017, 9:35 PM

Should I split out the OCD-part in a separate commit in the future? :D

mat added a comment.Feb 1 2017, 9:50 PM

You should not reorder things :-)

Revision Contents
Changeset List

PathSize
head/
misc/
tellico-kde4/
19 lines
5 lines

Diff 24630

View Options

head/misc/tellico-kde4/Makefile

Loading...
View Options

head/misc/tellico-kde4/distinfo

Loading...