Page MenuHomeFreeBSD
Differential D9372

Reimplement linux_arch_prctl() as a wrapper around sysarch().
ClosedPublic
Actions

Authored by trasz on Jan 29 2017, 2:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 18, 5:20 AM
Unknown Object (File)
Thu, Apr 18, 4:13 AM
Unknown Object (File)
Wed, Apr 17, 12:57 PM
Unknown Object (File)
Dec 20 2023, 6:58 AM
Unknown Object (File)
Sep 12 2023, 4:50 PM
Unknown Object (File)
Jul 16 2023, 7:01 AM
Unknown Object (File)
Jun 27 2023, 9:17 AM
Unknown Object (File)
Jun 21 2023, 2:40 PM
View All 14 Files
Subscribers
imp

Details

Reviewers
kib
dchagin
Commits
rS313993: Reimplement linux_arch_prctl() as a wrapper around sysarch(2).
Summary

Reimplement linux_arch_prctl() as a wrapper around sysarch().
It also adds support for LINUX_ARCH_SET_GS.

Dmitri, could you test it? Thanks!

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz updated this revision to Diff 24536.Jan 29 2017, 2:56 PM
trasz retitled this revision from to Reimplement linux_arch_prctl() as a wrapper around sysarch()..
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
Herald added a subscriber: imp. · View Herald TranscriptJan 29 2017, 2:56 PM
trasz added reviewers: dchagin, kib.Jan 29 2017, 2:57 PM

Forgot to mention - it changes the ordering in the case() statement to match the order of declarations of contants.

kib added inline comments.Jan 29 2017, 3:17 PM
sys/amd64/linux/linux_machdep.c
250 ↗(On Diff #24536)

Shouldn't you reimplement linux_set_cloned_tls() using sysarch() as well ?

trasz added a comment.Feb 11 2017, 3:25 PM

I should, but it's called from entirely different codepaths, and I'd prefer to not mix things at this point, since it makes debugging regressions harder.

dchagin accepted this revision.Feb 18 2017, 5:02 PM
dchagin edited edge metadata.

I did not this because I was planning to change the test of user supplied addr value against VM_MAXUSER_ADDRESS as since vdso the upper limit of address space is less than VM_MAXUSER_ADDRESS

sys/amd64/linux/linux_machdep.c
68 ↗(On Diff #24536)

garbage?

This revision is now accepted and ready to land.Feb 18 2017, 5:02 PM
Closed by commit rS313993: Reimplement linux_arch_prctl() as a wrapper around sysarch(2). (authored by trasz). · Explain WhyFeb 20 2017, 4:13 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
linux/
35 lines

Diff 25427

View Options

head/sys/amd64/linux/linux_machdep.c

Loading...