Page MenuHomeFreeBSD
Differential D9279

Use time_t for intermediate values to avoid overflow in clock_ts_to_ct
ClosedPublic
Actions

Authored by cem on Jan 21 2017, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 2:26 PM
Unknown Object (File)
Mon, Oct 28, 2:53 AM
Unknown Object (File)
Oct 20 2024, 4:22 PM
Unknown Object (File)
Oct 4 2024, 11:21 PM
Unknown Object (File)
Oct 3 2024, 10:04 PM
Unknown Object (File)
Oct 2 2024, 6:00 AM
Unknown Object (File)
Oct 1 2024, 1:43 AM
Unknown Object (File)
Sep 30 2024, 11:20 PM
View All Files
Subscribers
None

Details

Reviewers
kib
jhb
Commits
rS312702: Use time_t for intermediate values to avoid overflow in clock_ts_to_ct
Summary

Add additionally safety and overflow checks to clock_ts_to_ct and the
BCD routines while we're here.

PR: 211960
Submitted by: Justin McOmie <justin.mcomie at gmail.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cem updated this revision to Diff 24284.Jan 21 2017, 6:37 PM
cem retitled this revision from to Use time_t for intermediate values to avoid overflow in clock_ts_to_ct.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: jhb, kib.
kib added inline comments.Jan 22 2017, 5:02 PM
sys/kern/subr_clock.c
218 ↗(On Diff #24284)

Theoretically, this is a right assert to have (modulo the upper cap on the acceptable years value). Practically, this means that the assert can be immediately triggered from userspace by root. See PR 214300 for the my thought about complete fix and the reciprocal workaround.

Be assured that bde also has opinion on this stuff.

sys/sys/libkern.h
52 ↗(On Diff #24284)

Do not use protected namespace for normal code.

cem updated this revision to Diff 24389.Jan 24 2017, 5:13 PM

Add additional safety belt in clock_settime() per patch in pr 214300.

kib accepted this revision.Jan 24 2017, 5:24 PM
kib edited edge metadata.

Please do change __LEN_XXX to something that does not belong to implementation namespace.

This revision is now accepted and ready to land.Jan 24 2017, 5:24 PM
cem added a comment.Jan 24 2017, 5:36 PM
In D9279#192569, @kib wrote:

Please do change __LEN_XXX to something that does not belong to implementation namespace.

Ah, forgot about that. Sorry, just a minute.

cem updated this revision to Diff 24391.Jan 24 2017, 5:39 PM
cem edited edge metadata.

Replace __ prefix with LIBKERN_, to avoid name clashes without using reserved
namespace.

This revision now requires review to proceed.Jan 24 2017, 5:39 PM
kib accepted this revision.Jan 24 2017, 5:48 PM
kib edited edge metadata.
This revision is now accepted and ready to land.Jan 24 2017, 5:48 PM
Closed by commit rS312702: Use time_t for intermediate values to avoid overflow in clock_ts_to_ct (authored by cem). · Explain WhyJan 24 2017, 6:05 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
kern/
7 lines
16 lines
libkern/
4 lines
sys/
33 lines

Diff 24394

View Options

head/sys/kern/kern_time.c

Loading...
View Options

head/sys/kern/subr_clock.c

Loading...
View Options

head/sys/libkern/bcd.c

Loading...
View Options

head/sys/sys/libkern.h

Loading...