Page MenuHomeFreeBSD
Differential D9250

Update default GEM_NAME
ClosedPublic
Actions

Authored by sunpoet on Jan 19 2017, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 7:05 AM
Unknown Object (File)
Mon, Oct 14, 12:04 AM
Unknown Object (File)
Sun, Oct 13, 6:09 AM
Unknown Object (File)
Oct 3 2024, 9:02 PM
Unknown Object (File)
Oct 3 2024, 4:33 PM
Unknown Object (File)
Oct 3 2024, 5:41 AM
Unknown Object (File)
Oct 3 2024, 2:20 AM
Unknown Object (File)
Oct 2 2024, 9:45 PM
View All 72 Files
Subscribers
mat
swills

Details

Reviewers
sunpoet
swills
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
Ruby
portmgr
Commits
rP432064: Update default GEM_NAME
Summary

Change default GEM_NAME from ${PORTNAME}-${PORTVERSION} to ${DISTNAME} to avoid unnecessary GEM_NAME setting in ports Makefile.

Test Plan

exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 6889
Build 7080: arc lint + arc unit

Event Timeline

sunpoet updated this revision to Diff 24213.Jan 19 2017, 7:40 PM
sunpoet retitled this revision from to Update default GEM_NAME.
sunpoet updated this object.
sunpoet edited the test plan for this revision. (Show Details)
sunpoet added a reviewer: Ruby.
Owners added a reviewer: O5: Ports Framework.Jan 19 2017, 7:40 PM
Herald added a reviewer: portmgr. · View Herald TranscriptJan 19 2017, 7:40 PM
Herald added a subscriber: mat. · View Herald Transcript
sunpoet accepted this revision.Jan 21 2017, 5:10 PM
sunpoet added a reviewer: sunpoet.
sunpoet added a commit: rP432064: Update default GEM_NAME.Jan 21 2017, 5:35 PM
swills added a subscriber: swills.Apr 17 2017, 7:04 PM

This was committed, please close the review or I guess I'll have to commandeer it and then close it.

sunpoet added a comment.Apr 17 2017, 7:06 PM

I cannot close it due to lack for portmgr approval here.

sunpoet mentioned this in D9162: Remove superfluous space.Apr 17 2017, 7:56 PM
swills accepted this revision.Apr 18 2017, 1:38 PM

Seems pointless to approve after it was committed, but if it allows the change to be closed, fine.

This revision is now accepted and ready to land.Apr 18 2017, 1:38 PM
sunpoet closed this revision.Apr 18 2017, 1:51 PM

Thanks!

Revision Contents
Changeset List

PathSize
Mk/
Uses/
2 lines
converters/
rubygem-bsdconv/
1 line
devel/
rubygem-ascii85/
2 lines
rubygem-io-like/
2 lines
rubygem-platform/
3 lines
rubygem-popen4/
4 lines
rubygem-ptreloaded/
3 lines
rubygem-rubyinline/
1 line
rubygem-rubyinlineaccel/
3 lines
rubygem-zentest/
1 line
security/
ruby-hmac/
1 line
rubygem-jugyo-twitter_oauth/
1 line
rubygem-razorback-scriptNugget/
2 lines
sysutils/
rubygem-sys-proctable/
1 line
textproc/
rubygem-rugments/
2 lines
www/
rubygem-redcloth/
1 line

Diff 24213

View Options

Mk/Uses/gem.mk

Loading...
View Options

converters/rubygem-bsdconv/Makefile

Loading...
View Options

devel/rubygem-ascii85/Makefile

Loading...
View Options

devel/rubygem-io-like/Makefile

Loading...
View Options

devel/rubygem-platform/Makefile

Loading...
View Options

devel/rubygem-popen4/Makefile

Loading...
View Options

devel/rubygem-ptreloaded/Makefile

Loading...
View Options

devel/rubygem-rubyinline/Makefile

Loading...
View Options

devel/rubygem-rubyinlineaccel/Makefile

Loading...
View Options

devel/rubygem-zentest/Makefile

Loading...
View Options

security/ruby-hmac/Makefile

Loading...
View Options

security/rubygem-jugyo-twitter_oauth/Makefile

Loading...
View Options

security/rubygem-razorback-scriptNugget/Makefile

Loading...
View Options

sysutils/rubygem-sys-proctable/Makefile

Loading...
View Options

textproc/rubygem-rugments/Makefile

Loading...
View Options

www/rubygem-redcloth/Makefile

Loading...