Details
Details
- Reviewers
AMDmi3 sunpoet swills - Group Reviewers
O5: Ports Framework (Owns No Changed Paths) portmgr - Commits
- rP435394: Remove superfluous space
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 7789 Build 7934: arc lint + arc unit
Event Timeline
Comment Actions
Apart from one bit, others are probably good after we've dropped fmake. Please also fix another bit in bsd.licenses.db.mk
Mk/bsd.licenses.mk | ||
---|---|---|
719 | This one is prone to += problem. |
Comment Actions
Just to sure you're aware, the reason these spaces were added is the presence of licenses like "GPLv2+". The problem is that naive
LICENSE_FILE_GPLv2+=foo
will be interpreted as
(LICENSE_FILE_GPLv2)(+=)(foo)
while
(LICENSE_FILE_GPLv2+)(=)(foo)
is meant. With fmake, the problem is there even in substitutions like
lic=GPLv2+ LICENSE_FILE_${lic}=foo
but as fmake is gone, this is fixed. The echo, however, will output verbatim make code which is prone to += problem, so the space there may not be removed.
Comment Actions
Thanks for the explanation. A newer version including Mk/bsd.licenses.db.mk was submitted.
Comment Actions
Same as I replied in D9250.
Since you are member of portmgr, please approve it and then I could close it.