Page MenuHomeFreeBSD

Update default GEM_NAME
ClosedPublic

Authored by sunpoet on Jan 19 2017, 7:40 PM.

Details

Reviewers
sunpoet
swills
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
Ruby
portmgr
Commits
rP432064: Update default GEM_NAME
Summary

Change default GEM_NAME from ${PORTNAME}-${PORTVERSION} to ${DISTNAME} to avoid unnecessary GEM_NAME setting in ports Makefile.

Test Plan

exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 6889
Build 7080: arc lint + arc unit

Event Timeline

sunpoet retitled this revision from to Update default GEM_NAME.Jan 19 2017, 7:40 PM
sunpoet updated this object.
sunpoet edited the test plan for this revision. (Show Details)
sunpoet added a reviewer: Ruby.
sunpoet updated this revision to Diff 24213.
sunpoet accepted this revision.
swills added a subscriber: swills.Apr 17 2017, 7:04 PM

This was committed, please close the review or I guess I'll have to commandeer it and then close it.

I cannot close it due to lack for portmgr approval here.

swills accepted this revision.Apr 18 2017, 1:38 PM

Seems pointless to approve after it was committed, but if it allows the change to be closed, fine.

This revision is now accepted and ready to land.Apr 18 2017, 1:38 PM
sunpoet closed this revision.Apr 18 2017, 1:51 PM

Thanks!