Page MenuHomeFreeBSD

Corrected handling of fifth parameter in DTrace's FBT provider for ARM
ClosedPublic

Authored by graeme.jenkinson_cl.cam.ac.uk on Jan 18 2017, 11:13 AM.

Details

Summary

DTrace's FBT for ARM attempts to access the user stack pointer, in order to provide the fifth parameter in the call to dtrace_probe. This results in a translation error.

Test Plan

Verified the correct operation of the FBT provider on BeagleBone Black whilst instrumenting fbt::malloc:entry, fbt::vm_fault:entry and fbt:::.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

graeme.jenkinson_cl.cam.ac.uk retitled this revision from to Corrected handling of fifth parameter in DTrace's FBT provider for ARM .Jan 18 2017, 11:13 AM
graeme.jenkinson_cl.cam.ac.uk updated this object.
graeme.jenkinson_cl.cam.ac.uk edited the test plan for this revision. (Show Details)
graeme.jenkinson_cl.cam.ac.uk set the repository for this revision to rS FreeBSD src repository.
graeme.jenkinson_cl.cam.ac.uk updated this revision to Diff 24151.
andrew edited edge metadata.Jan 18 2017, 12:02 PM
andrew accepted this revision.
This revision is now accepted and ready to land.Jan 18 2017, 12:02 PM
This revision was automatically updated to reflect the committed changes.