loader: move device path definitions to include/efidevp.h
ClosedPublic
Actions

Authored by tsoome on Jan 15 2017, 8:45 PM.

Details

Reviewers

jhb
allanjude
imp

Commits

rS312314: loader: move device path definitions to include/efidevp.h

Summary

No functional change, only moving uuid and protocol bits to include/efidevp.h

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome updated this revision to Diff 24039.Jan 15 2017, 8:45 PM

tsoome retitled this revision from to loader: move device path definitions to include/efidevp.h.

tsoome updated this object.

tsoome edited the test plan for this revision. (Show Details)

tsoome added reviewers: allanjude, imp.

tsoome added a reviewer: jhb.Jan 15 2017, 8:48 PM

This is fine.

We may wish at looking at doing the heavy lift of rebase our stuff to more modern UEFI upstream sources sometime.
Also need to look at sharing between UEFI boot loader and the new user land stuff.

This revision is now accepted and ready to land.Jan 16 2017, 7:24 PM

jhb accepted this revision.Jan 16 2017, 7:37 PM

jhb edited edge metadata.

jhb added inline comments.

sys/boot/efi/libefi/devpath.c
33 ↗	(On Diff #24039)	I would keep this XXX as it is still true. It isn't something private to the loader, but something from the EFI spec, though perhaps the comment should cover a larger range of stuff in efidevp.h?

tsoome added inline comments.Jan 16 2017, 8:14 PM

sys/boot/efi/libefi/devpath.c
33 ↗	(On Diff #24039)	Well, the efidevp.h has the device path related bits, so, its not just larger, but entire file. As for an example, the edk2 has this tree in MdePkg/Include/Protocol/ DeviceIo.h DevicePathFromText.h DevicePathUtilities.h DevicePath.h DevicePathToText.h In that sense, that comment is applicable to entire current efi*.h content.