mail/dovecot2-pigeonhole: lib-sieve: Fixed handling of an early explicit keep during multiscript execution.

[ler]

Summary

mail/dovecot2-pigeonhole: lib-sieve: Fixed handling of an early explicit keep during multiscript execution.

Applies to LDA/LMTP context in general, not only when sieve_before/sieve_after are used.
Action side-effects and the message snapshot would be lost at the final stage where the implicit keep is evaluated.
This happened because the keep action itself is not actually executed, but rather its presence is noted to determine whether more scripts need to be executed.
So, when finally execution of the actual keep action is due, i.e. when there are no more scripts in the sequence, it overrides the explicit keep from the last script.
This didn't take the side-effects and message snapshot into account.

add upstream patch: https://github.com/dovecot/pigeonhole/commit/772485538302957ebada484b6eedec57136bc737

Approved by: (adamw|rene) (Mentor)

Test Plan

poudriere (ok)

[ler]

grr. The lsof stuff won't be committed in this rev.
need to figure out how to get arcanist to JUST do that directory.

[ler]

update PORTREVISION, kill lsof

[adamw]

Approved. Great commit message too! Just change "add upstream patch" to "Obtained from:" (it's one of the automatic fields).