audio/teamspeak3-server: unbreak on 11-STABLE

[lifanov]

Summary

audio/teamspeak3-server: unbreak on 11-STABLE

 PR: 212237
 Reported by: Jonathan Price <[e-mail]>
 Submitted by: [e-mail] (maintainer)
 Reviewed by: matthew
 Approved by: matthew (mentor)
 Differential Revision: https://reviews.freebsd.org/D9170

[mat]

Have you tested this ? Because it cannot possibly work, OSVERSION is only defined after bsd.port.options.mk is included. (Testing in poudriere won't work, it defines OSVERSION in the environement to fake things up.)

You need to move this lower in the Makefile and change it to something like:

.if OSVERSION > 110000 && OSVERSION < <your version>
BROKEN=
.endif

[matthew]

Missing the PR number?

audio/teamspeak3-server/Makefile

23

This doesn't work -- it's too early to reference ${OSVERSION} here. Has to be after the inclusion of bsd.ports.pre.mk or bsd.port.options.mk

Also, probably better to use the style:

.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1100000 && ${OSVERSION} < 1100507
BROKEN=Will not start on FreeBSD 11, Bug 212493
.endif

rather than mixing an explicit test against OSVERSION with the 'BROKEN_FreeBSD_11' form.

[matthew]

In D9170#189493, @mat wrote:

Have you tested this ? Because it cannot possibly work, OSVERSION is only defined after bsd.port.options.mk is included. (Testing in poudriere won't work, it defines OSVERSION in the environement to fake things up.)

You need to move this lower in the Makefile and change it to something like:

.if OSVERSION > 110000 && OSVERSION < <your version>
BROKEN=
.endif

The port is marked restricted, so it wouldn't build under poudriere even if it was syntactically correct.

[lifanov]

fix and switch to a single version check mechanism

I didn't test this previously because of the RESTRICTED, but I tested the version just now with LICENSE* and RESTRICTED commented out and it works.

[matthew]

Builds fine on 11-STABLE r310632