Page MenuHomeFreeBSD
Differential D9155

textproc/rubygem-terminal-table: Add rubygem-unicode-display_width to RUN_DEPENDS
ClosedPublic
Actions

Authored by dumbbell on Jan 12 2017, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 25 2024, 2:01 PM
Unknown Object (File)
Sep 25 2024, 2:00 PM
Unknown Object (File)
Sep 25 2024, 2:00 PM
Unknown Object (File)
Sep 25 2024, 2:00 PM
Unknown Object (File)
Sep 25 2024, 1:49 PM
Unknown Object (File)
Sep 11 2024, 6:35 AM
Unknown Object (File)
Sep 11 2024, 6:28 AM
Unknown Object (File)
Sep 11 2024, 6:27 AM
View All 69 Files
Subscribers
mat

Details

Reviewers
antoine
bapt
Group Reviewers
Ruby
Commits
rP431294: textprox/rubygem-terminal-table: Add unicode-display_width to RUN_DEPENDS
Summary

It looks like this gem now depends on unicode-display_width at runtime.

I noticed it when sysutils/rubygem-bosh_cli broke after several gems were updated.

I patched the gemspec to make the version requirement on unicode-display_width less strict, after seeing what was done in other gem ports.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dumbbell updated this revision to Diff 23931.Jan 12 2017, 5:42 PM
dumbbell retitled this revision from to textproc/rubygem-terminal-table: Add rubygem-unicode-display_width to RUN_DEPENDS.
dumbbell updated this object.
dumbbell edited the test plan for this revision. (Show Details)
dumbbell added reviewers: Ruby, antoine, bapt.
Herald added a subscriber: mat. · View Herald TranscriptJan 12 2017, 5:42 PM
dumbbell updated this object.Jan 12 2017, 5:43 PM
dumbbell updated this object.
antoine requested changes to this revision.Jan 12 2017, 6:10 PM
antoine edited edge metadata.
antoine added inline comments.
textproc/rubygem-terminal-table/Makefile
6 ↗(On Diff #23931)

PORTREVISION has to be bumped to 1 as the package changes

textproc/rubygem-terminal-table/files/patch-terminal-table.gemspec
8 ↗(On Diff #23931)

I believe this patch is not necessary.
The ports tree has version 1.1.2 which satisfies ~> 1.1.1
(~> 1.1.1 means >= 1.1.1 and < 1.2.0)

This revision now requires changes to proceed.Jan 12 2017, 6:10 PM
dumbbell updated this revision to Diff 23933.Jan 12 2017, 6:15 PM
dumbbell edited edge metadata.

Bump PORTREVISION + do not patch gemspec

antoine accepted this revision.Jan 12 2017, 6:32 PM
antoine edited edge metadata.

looks fine!

This revision is now accepted and ready to land.Jan 12 2017, 6:32 PM
Closed by commit rP431294: textprox/rubygem-terminal-table: Add unicode-display_width to RUN_DEPENDS (authored by dumbbell). · Explain WhyJan 12 2017, 7:00 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
textproc/
rubygem-terminal-table/
3 lines

Diff 23937

View Options

head/textproc/rubygem-terminal-table/Makefile

Loading...