Page MenuHomeFreeBSD
Differential D9152

Fix usage()
ClosedPublic
Actions

Authored by garga on Jan 12 2017, 1:02 PM.
Tags
None
Referenced Files
F114705854: D9152.id25189.diff
Tue, Apr 15, 5:14 PM
Unknown Object (File)
Mon, Apr 14, 6:18 AM
Unknown Object (File)
Mon, Apr 14, 3:21 AM
Unknown Object (File)
Mon, Apr 14, 2:54 AM
Unknown Object (File)
Mon, Apr 14, 2:49 AM
Unknown Object (File)
Mon, Apr 14, 2:46 AM
Unknown Object (File)
Mon, Apr 14, 2:21 AM
Unknown Object (File)
Mon, Apr 14, 12:59 AM
View All 96 Files
Subscribers
imp

Details

Reviewers
kib
allanjude
loos
Group Reviewers
manpages
Commits
rS314042: MFC r313745:
rS313745: * Add missing parameters to usage()
Summary
  • Add missing parameters to usage()
  • Add missing parameters to manpage synopsis
  • Add missing description of -d flag
  • Sort flags descriptions

Sponsored by: Rubicon Communications (Netgate)
MFC after: 1 week

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

garga updated this revision to Diff 23923.Jan 12 2017, 1:02 PM
garga retitled this revision from to Fix usage().
garga updated this object.
garga edited the test plan for this revision. (Show Details)
garga added a reviewer: loos.
Herald added a subscriber: imp. · View Herald TranscriptJan 12 2017, 1:02 PM
garga added a reviewer: allanjude.Feb 8 2017, 5:04 PM
allanjude edited edge metadata.Feb 8 2017, 6:02 PM

A bunch of these options appear to be missing from the fsck_ffs man page as well

allanjude added a reviewer: manpages.Feb 8 2017, 6:02 PM
garga updated this revision to Diff 25136.Feb 14 2017, 9:21 AM

Update manpage

Herald edited edge metadata. · View Herald TranscriptFeb 14 2017, 9:21 AM
garga added a comment.Feb 14 2017, 9:22 AM

The only option missing description was -d, other were only being missed in usage

garga updated this object.Feb 14 2017, 9:23 AM
garga added a reviewer: kib.
kib accepted this revision.Feb 14 2017, 6:36 PM
kib edited edge metadata.

Would be useful to order the descriptions of the flags alphabetically, as a follow-up.

This revision is now accepted and ready to land.Feb 14 2017, 6:36 PM
garga updated this revision to Diff 25184.Feb 14 2017, 8:26 PM
garga edited edge metadata.

Sort manpage flags descriptions

This revision now requires review to proceed.Feb 14 2017, 8:26 PM
Herald edited edge metadata. · View Herald TranscriptFeb 14 2017, 8:26 PM
garga updated this object.Feb 14 2017, 8:27 PM
garga edited edge metadata.
kib accepted this revision.Feb 14 2017, 8:34 PM
kib edited edge metadata.
This revision is now accepted and ready to land.Feb 14 2017, 8:34 PM
allanjude added a comment.Feb 14 2017, 8:48 PM

The synopsis lists -C, but it is not described in the man page anywhere.

It seems to only be in the fsck manpage

garga added a comment.Feb 14 2017, 8:57 PM

It's hidden in the patch because it was not touched by this commit but it's there at https://github.com/freebsd/freebsd/blob/master/sbin/fsck_ffs/fsck_ffs.8#L201

allanjude accepted this revision.Feb 14 2017, 9:06 PM
allanjude edited edge metadata.

Approved By: allanjude

Closed by commit rS313745: * Add missing parameters to usage() (authored by garga). · Explain WhyFeb 14 2017, 9:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sbin/
fsck_ffs/
84 lines
2 lines

Diff 25189

View Options

head/sbin/fsck_ffs/fsck_ffs.8

Loading...
View Options

head/sbin/fsck_ffs/main.c

Loading...