Page MenuHomeFreeBSD

Fix MSI IRQ allocation for ARM GIC
ClosedPublic

Authored by gonzo on Jan 11 2017, 7:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 22 2024, 1:33 AM
Unknown Object (File)
Jan 30 2024, 3:25 AM
Unknown Object (File)
Dec 16 2023, 12:37 PM
Unknown Object (File)
Dec 16 2023, 12:37 PM
Unknown Object (File)
Nov 23 2023, 12:12 AM
Unknown Object (File)
Nov 15 2023, 12:34 AM
Unknown Object (File)
Nov 13 2023, 6:07 PM
Unknown Object (File)
Oct 4 2023, 10:21 AM
Subscribers

Details

Summary

Code used wrong vartiable to check flags, irq does not change so only first IRQ is checked

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

gonzo retitled this revision from to Fix MSI IRQ allocation for ARM GIC.
gonzo updated this object.
gonzo edited the test plan for this revision. (Show Details)
gonzo added a reviewer: andrew.
sys/arm/arm/gic.c
1442–1443 ↗(On Diff #23899)

I think this assert will be hit when the allocation doesn't fit as sc->sc_spi_end isn't a MSI/MSI-X irq.

Overcome by events: fixed by r317428

Are the irq -> end_irq changes still relevant? They appear so.

Yeah, overlooked end_irq part, reopening

Sync patch to the latest HEAD version

This revision is now accepted and ready to land.Jun 22 2017, 3:55 PM
This revision was automatically updated to reflect the committed changes.